From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: alvherre@2ndquadrant.com
Cc: andres@anarazel.de
Cc: tomas.vondra@2ndquadrant.com
Cc: ah@cybertec.at
Cc: magnus@hagander.net
Cc: robertmhaas@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@postgresql.org
Subject: Re: shared-memory based stats collector
Date: Thu, 21 Feb 2019 17:30:50 +0300
Message-ID: <db346d14-4130-57a5-5f46-9a57e9982bec@postgrespro.ru> (raw)
In-Reply-To: <20190221.160555.191280262.horiguchi.kyotaro@lab.ntt.co.jp>
References: <20190215171655.ioxlfm5a2rrl6dzv@alap3.anarazel.de>
<20190215185328.GA29663@alvherre.pgsql>
<20190220.154517.24528798.horiguchi.kyotaro@lab.ntt.co.jp>
<20190221.160555.191280262.horiguchi.kyotaro@lab.ntt.co.jp>
Hello,
On 21.02.2019 10:05, Kyotaro HORIGUCHI wrote:
> Done. This verison 16 looks as if the moving and splitting were
> not happen. Major changes are:
>
> - Restored old pgstats_* names. This largily shrinks the patch
> size to less than a half lines of v15. More than that, it
> gets easier to examine differences. (checkpointer.c and
> bgwriter.c have a bit stale comments but it is an issue for
> later.)
>
> - Removed "oneshot" feature at all. This simplifies pgstat API
> and let this patch far less simple.
>
> - Moved StatsLock to LWTRANCHE_STATS, which is not necessary to
> be in the main tranche.
>
> - Fixed several bugs revealed by the shrinked size of the patch.
I run regression tests. Unfortunately tests didn't pass, failed test is
'rangetypes':
rangetypes ... FAILED (test process exited with exit code 2)
It seems to me that an autovacuum process terminates because of segfault.
Segfault occurs within get_pgstat_tabentry_relid(). If I'm not mistaken,
somehow 'dbentry' hasn't valid pointer anymore.
'dbentry' is get in the line in do_autovacuum():
dbentry = pgstat_fetch_stat_dbentry(MyDatabaseId);
'dbentry' becomes invalid after calling pgstat_vacuum_stat().
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, horiguchi.kyotaro@lab.ntt.co.jp, alvherre@2ndquadrant.com, andres@anarazel.de, tomas.vondra@2ndquadrant.com, ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: shared-memory based stats collector
In-Reply-To: <db346d14-4130-57a5-5f46-9a57e9982bec@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox