public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 08/10] Default to zstd.. 4+ messages / 4 participants [nested] [flat]
* [PATCH 08/10] Default to zstd.. @ 2021-03-12 21:35 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw) for CI, not for merge --- configure | 6 ++++-- configure.ac | 2 +- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 20c6e08c02..dffe70208b 100755 --- a/configure +++ b/configure @@ -1582,7 +1582,7 @@ Optional Packages: use system time zone data in DIR --without-zlib do not use Zlib --without-lz4 build without LZ4 support - --with-zstd build with Zstd compression library + --without-zstd build without Zstd compression library --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8740,7 +8740,9 @@ $as_echo "#define USE_ZSTD 1" >>confdefs.h esac else - with_zstd=no + with_zstd=yes + +$as_echo "#define USE_ZSTD 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index c4956745ce..780c0e785f 100644 --- a/configure.ac +++ b/configure.ac @@ -1005,7 +1005,7 @@ fi # ZSTD # AC_MSG_CHECKING([whether to build with zstd support]) -PGAC_ARG_BOOL(with, zstd, no, [build with Zstd compression library], +PGAC_ARG_BOOL(with, zstd, yes, [build without Zstd compression library], [AC_DEFINE([USE_ZSTD], 1, [Define to 1 to build with zstd support. (--with-zstd)])]) AC_MSG_RESULT([$with_zstd]) AC_SUBST(with_zstd) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 9bac79b579..5a8447a525 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -99,7 +99,7 @@ bool EnableHotStandby = false; bool fullPageWrites = true; bool wal_log_hints = false; bool wal_compression = false; -int wal_compression_method = WAL_COMPRESSION_LZ4; +int wal_compression_method = WAL_COMPRESSION_ZSTD; char *wal_consistency_checking_string = NULL; bool *wal_consistency_checking = NULL; bool wal_init_zero = true; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 52f9cd0242..8031e027aa 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] = NULL }, &wal_compression_method, - WAL_COMPRESSION_LZ4, wal_compression_options, + WAL_COMPRESSION_ZSTD, wal_compression_options, NULL, NULL, NULL }, -- 2.17.0 --0qVF/w3MHQqLSynd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0009-Add-zstd-compression-levels.patch" ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Assert in heapgettup_pagemode() fails due to underlying buffer change @ 2024-06-06 16:36 Robert Haas <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Robert Haas @ 2024-06-06 16:36 UTC (permalink / raw) To: Alexander Lakhin <[email protected]>; +Cc: pgsql-hackers On Thu, Jun 6, 2024 at 6:00 AM Alexander Lakhin <[email protected]> wrote: > Am I missing something or the the page buffer indeed lacks locking there? I don't know, but if the locks are really missing now, I feel like the first question is "which commit got rid of them?". It's a little hard to believe that they've never been there and somehow nobody has noticed. Then again, maybe we have; see Noah's thread about in-place updates breaking stuff and some of the surprising discoveries there. But it seems worth investigating. -- Robert Haas EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Assert in heapgettup_pagemode() fails due to underlying buffer change @ 2024-06-06 19:07 Noah Misch <[email protected]> parent: Robert Haas <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Noah Misch @ 2024-06-06 19:07 UTC (permalink / raw) To: Robert Haas <[email protected]>; +Cc: Alexander Lakhin <[email protected]>; pgsql-hackers On Thu, Jun 06, 2024 at 12:36:32PM -0400, Robert Haas wrote: > On Thu, Jun 6, 2024 at 6:00 AM Alexander Lakhin <[email protected]> wrote: > > Am I missing something or the the page buffer indeed lacks locking there? > > I don't know, but if the locks are really missing now, I feel like the > first question is "which commit got rid of them?". It's a little hard > to believe that they've never been there and somehow nobody has > noticed. > > Then again, maybe we have; see Noah's thread about in-place updates > breaking stuff and some of the surprising discoveries there. But it > seems worth investigating. $SUBJECT looks more like a duplicate of postgr.es/m/flat/[email protected] (Hot standby queries see transient all-zeros pages). ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Assert in heapgettup_pagemode() fails due to underlying buffer change @ 2024-06-07 03:00 Alexander Lakhin <[email protected]> parent: Noah Misch <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Alexander Lakhin @ 2024-06-07 03:00 UTC (permalink / raw) To: Noah Misch <[email protected]>; Robert Haas <[email protected]>; +Cc: pgsql-hackers; Thomas Munro <[email protected]> Hello Noah, 06.06.2024 22:07, Noah Misch wrote: > >> I don't know, but if the locks are really missing now, I feel like the >> first question is "which commit got rid of them?". It's a little hard >> to believe that they've never been there and somehow nobody has >> noticed. >> >> Then again, maybe we have; see Noah's thread about in-place updates >> breaking stuff and some of the surprising discoveries there. But it >> seems worth investigating. > $SUBJECT looks more like a duplicate of > postgr.es/m/flat/[email protected] (Hot standby queries see > transient all-zeros pages). Thank you for the reference! Yes, it looks very similar. Though I can't say the sleep you proposed helps the failure reproduction (I've tried 026_overwrite_contrecord.pl and saw no more frequent failures or so). My bisect run ended with: 210622c60e1a9db2e2730140b8106ab57d259d15 is the first bad commit Author: Thomas Munro <[email protected]> Date: Wed Apr 3 00:03:08 2024 +1300 Provide vectored variant of ReadBuffer(). Other buildfarm failures with this Assert I could find kind of confirm this: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=calliphoridae&dt=2024-04-03%2003%3A32%3A... (presumably a first failure of this sort) https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tamandua&dt=2024-04-04%2015%3A38%3A16 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=margay&dt=2024-05-07%2004%3A00%3A08 Best regards, Alexander ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-06-07 03:00 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-12 21:35 [PATCH 08/10] Default to zstd.. Justin Pryzby <[email protected]> 2024-06-06 16:36 Re: Assert in heapgettup_pagemode() fails due to underlying buffer change Robert Haas <[email protected]> 2024-06-06 19:07 ` Re: Assert in heapgettup_pagemode() fails due to underlying buffer change Noah Misch <[email protected]> 2024-06-07 03:00 ` Re: Assert in heapgettup_pagemode() fails due to underlying buffer change Alexander Lakhin <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox