pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: partitioned tables referenced by FKs
Date: Fri, 29 Mar 2019 12:45:35 -0400
Message-ID: <dc3eccb5-e408-f1ea-96bd-a3149f72b785@redhat.com> (raw)
In-Reply-To: <20190329162933.GA1906@alvherre.pgsql>
References: <20190329162933.GA1906@alvherre.pgsql>

Hi,

On 3/29/19 12:29 PM, Alvaro Herrera wrote:
> On 2019-Mar-29, Jesper Pedersen wrote:
>> Maybe the "(" / ")" in the CASCADE description should be removed from
>> ref/drop_table.sgml as part of this patch.
> 
> I'm not sure what text you propose to remove?
>

Just the attached.

>> Should catalogs.sgml be updated for this case ?
> 
> I'm not adding any new dependency type, nor modifying any existing one.
> Are you looking at anything that needs changing specifically?
> 

No, I just mentioned it if it was a requirement that the precise 
use-case for each dependency type were documented.

Best regards,
  Jesper
diff --git a/doc/src/sgml/ref/drop_table.sgml b/doc/src/sgml/ref/drop_table.sgml
index bf8996d198..328157c849 100644
--- a/doc/src/sgml/ref/drop_table.sgml
+++ b/doc/src/sgml/ref/drop_table.sgml
@@ -41,9 +41,9 @@ DROP TABLE [ IF EXISTS ] <replaceable class="parameter">name</replaceable> [, ..
    triggers, and constraints that exist for the target table.
    However, to drop a table that is referenced by a view or a foreign-key
    constraint of another table, <literal>CASCADE</literal> must be
-   specified. (<literal>CASCADE</literal> will remove a dependent view entirely,
+   specified. <literal>CASCADE</literal> will remove a dependent view entirely,
    but in the foreign-key case it will only remove the foreign-key
-   constraint, not the other table entirely.)
+   constraint, not the other table entirely.
   </para>
  </refsect1>
 


Attachments:

  [text/plain] droptable.txt (851B, ../dc3eccb5-e408-f1ea-96bd-a3149f72b785@redhat.com/2-droptable.txt)
  download | inline diff:
diff --git a/doc/src/sgml/ref/drop_table.sgml b/doc/src/sgml/ref/drop_table.sgml
index bf8996d198..328157c849 100644
--- a/doc/src/sgml/ref/drop_table.sgml
+++ b/doc/src/sgml/ref/drop_table.sgml
@@ -41,9 +41,9 @@ DROP TABLE [ IF EXISTS ] <replaceable class="parameter">name</replaceable> [, ..
    triggers, and constraints that exist for the target table.
    However, to drop a table that is referenced by a view or a foreign-key
    constraint of another table, <literal>CASCADE</literal> must be
-   specified. (<literal>CASCADE</literal> will remove a dependent view entirely,
+   specified. <literal>CASCADE</literal> will remove a dependent view entirely,
    but in the foreign-key case it will only remove the foreign-key
-   constraint, not the other table entirely.)
+   constraint, not the other table entirely.
   </para>
  </refsect1>
 


view thread (61+ messages)  latest in thread

Message-ID: <dc3eccb5-e408-f1ea-96bd-a3149f72b785@redhat.com>
Permalink:  ../dc3eccb5-e408-f1ea-96bd-a3149f72b785@redhat.com/
Also on:    postgresql.org/message-id/dc3eccb5-e408-f1ea-96bd-a3149f72b785@redhat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jesper.pedersen@redhat.com, alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp
  Subject: Re: partitioned tables referenced by FKs
  In-Reply-To: <dc3eccb5-e408-f1ea-96bd-a3149f72b785@redhat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox