public inbox for [email protected]  

help / color / mirror / Atom feed

From: Sergey Tatarintsev <[email protected]>
To: Shlok Kyal <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: vignesh C <[email protected]>
Cc: [email protected]
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
Date: Fri, 4 Apr 2025 12:06:49 +0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANhcyEXVPUAir9G1G1gT9k-xAMzhiV7GRX_fr1rkRhURNKDbxg@mail.gmail.com>
References: <CANhcyEU5R4qdkO8SLSswRWgBRDPEaapAQ61rCjjDBg4RNmmsrw@mail.gmail.com>
	<[email protected]>
	<CANhcyEXVPUAir9G1G1gT9k-xAMzhiV7GRX_fr1rkRhURNKDbxg@mail.gmail.com>

01.04.2025 21:48, Shlok Kyal пишет:
> On Fri, 28 Mar 2025 at 16:35, Álvaro Herrera <[email protected]> wrote:
>> On 2025-Mar-28, Shlok Kyal wrote:
>>
>>> On Mon, 24 Mar 2025 at 21:17, Álvaro Herrera <[email protected]> wrote:
>>>> Also, surely we should document this restriction in the SGML docs
>>>> somewhere.
>>> I have added comment in create_publication.sgml
>> Hmm, okay, but "We cannot" is not the style used in the documentation.
>> In addition, I think this mechanism should be mentioned in
>> logical-replication.sgml; currently there's a note in the Restrictions
>> section about foreign tables, which should be expanded to explain this.
>>
> I have modified the comment in create_publication.sgml and also added
> comment in the restrictions section of logical-replication.sgml.
> I have also added a more detailed explanation in comment of
> 'check_foreign_tables'
>
> I have attached the updated v11 patch.
>
>
> Thanks and Regards,
> Shlok Kyal

Hi!

I looked at the latest version of the patch, and think that we should 
free puboids list here:

diff --git a/src/backend/commands/tablecmds.c 
b/src/backend/commands/tablecmds.c
index 6a128f7bd4e..4254654cc24 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -20122,6 +20122,7 @@ ATExecAttachPartition(List **wqueue, Relation 
rel, PartitionCmd *cmd,
relname)));
                         }
                 }
+               list_free(puboids);
         }

         /*


-- 
With best regards,
Sergey Tatarintsev,
PostgresPro

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox