pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: partition tree inspection functions
Date: Fri, 27 Jul 2018 08:21:57 -0400
Message-ID: <dfd06fa1-ddb0-3dda-fa2f-8651fc52a174@redhat.com> (raw)
In-Reply-To: <9f371b71-7b4f-b51c-323c-ca62c4a4ffed@lab.ntt.co.jp>
References: <8d00e51a-9a51-ad02-d53e-ba6bf50b2e52@lab.ntt.co.jp>
	<5a560c9c-3722-1914-f34b-1de0ff3310d1@lab.ntt.co.jp>
	<CAOgcT0P8FC4Sat1ytVZgm09qd2bgMv-7pWpvU1HdBMKSah9r-w@mail.gmail.com>
	<d5f5b9a8-0c88-8043-2007-be37096bed39@lab.ntt.co.jp>
	<20180627121615.GF2667@paquier.xyz>
	<45e28062-976d-45bf-56f8-9746f551da02@lab.ntt.co.jp>
	<20180628034341.GH11054@paquier.xyz>
	<6baeb45a-6222-6b88-342d-37fc7d3cf89a@lab.ntt.co.jp>
	<4f4a2518-6c62-5463-6ac2-1241ae9d6041@redhat.com>
	<e12ff710-dcf5-18ff-b4a4-cc42432d84c4@lab.ntt.co.jp>
	<38183355-ea7c-9443-0c38-6124fcf5f38b@redhat.com>
	<5686970f-b4e8-bbe5-9109-b97763714c19@lab.ntt.co.jp>
	<da9f8b6d-13bb-18fe-7777-b3be7bdd327b@redhat.com>
	<3273a7af-3aca-eb86-cedb-f7b28be00831@lab.ntt.co.jp>
	<2780ebf9-99ae-b433-2d0c-dbca2995956a@redhat.com>
	<9f371b71-7b4f-b51c-323c-ca62c4a4ffed@lab.ntt.co.jp>

Hi Amit,

On 07/26/2018 10:33 PM, Amit Langote wrote:
> Optional parameter sounds good, so made it get_partition_level(regclass [
> , regclass ]) in the updated patch.  Although, adding that argument is not
> without possible surprises its result might evoke.  Like, what happens if
> you try to find the level of the root table by passing a leaf partition
> oid for the root table argument, or pass a totally unrelated table for the
> root table argument.  For now, I've made the function return 0 for such cases.
> 

As 0 is a valid return value for root nodes I think we should use -1 
instead for these cases.

Otherwise looks good.

Best regards,
  Jesper




view thread (74+ messages)  latest in thread

Message-ID: <dfd06fa1-ddb0-3dda-fa2f-8651fc52a174@redhat.com>
Permalink:  ../dfd06fa1-ddb0-3dda-fa2f-8651fc52a174@redhat.com/
Also on:    postgresql.org/message-id/dfd06fa1-ddb0-3dda-fa2f-8651fc52a174@redhat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jesper.pedersen@redhat.com, Langote_Amit_f8@lab.ntt.co.jp, michael@paquier.xyz, jeevan.ladhe@enterprisedb.com
  Subject: Re: partition tree inspection functions
  In-Reply-To: <dfd06fa1-ddb0-3dda-fa2f-8651fc52a174@redhat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox