pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Date: Mon, 23 Sep 2024 16:00:00 +0300
Message-ID: <e012fb69-ca34-7e0e-3a33-b16d9737e526@gmail.com> (raw)
In-Reply-To: <Zu2oJtMI2avvjmtl@nathan>
References: <b611015f-b423-458c-aa2d-be0e655cc1b4@postgresql.org>
	<ZtipsVMZAGjrO1p_@nathan>
	<1679756.1725476893@sss.pgh.pa.us>
	<c500a379-7a20-4ab4-bcc9-5ea9aabe017a@postgresql.org>
	<ZuroEfWjxd4Zj6Yq@nathan>
	<1812111.1726671296@sss.pgh.pa.us>
	<ZusvlZBrPKm913LA@nathan>
	<a97d7401-e7c9-f771-6a00-037379f0a8bb@gmail.com>
	<ZuxvNDVfqpahqZNb@nathan>
	<adb7421f-eaf4-878a-6742-576fc6bf0d8f@gmail.com>
	<Zu2oJtMI2avvjmtl@nathan>

Hello Nathan,

20.09.2024 19:51, Nathan Bossart wrote:
> Here's a (probably naive) attempt at fixing these, too.  I'll give each
> path a closer look once it feels like we've identified all the bugs.

Thank you for the updated patch!

I tested it with two code modifications (1st is to make each created
expression index TOASTed (by prepending 1M of spaces to the indexeprs
value) and 2nd to make each created index an expression index (by
modifying index_elem_options in gram.y) — both modifications are kludgy so
I don't dare to publish them) and found no other snapshot-related issues
during `make check-world`.

Best regards,
Alexander





view thread (62+ messages)  latest in thread

Message-ID: <e012fb69-ca34-7e0e-3a33-b16d9737e526@gmail.com>
Permalink:  ../e012fb69-ca34-7e0e-3a33-b16d9737e526@gmail.com/
Also on:    postgresql.org/message-id/e012fb69-ca34-7e0e-3a33-b16d9737e526@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, nathandbossart@gmail.com, tgl@sss.pgh.pa.us, jkatz@postgresql.org, pgsql-hackers@lists.postgresql.org, michael@paquier.xyz
  Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
  In-Reply-To: <e012fb69-ca34-7e0e-3a33-b16d9737e526@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox