pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade version checking questions
Date: Tue, 2 Mar 2021 14:20:40 +0100
Message-ID: <e048d212-f72e-cff5-36fd-3e867e7d7267@2ndquadrant.com> (raw)
In-Reply-To: <22906594-DDD7-4085-8318-595C0C9C75C6@yesql.se>
References: <9328.1552952117@sss.pgh.pa.us>
	<pC-NMmh4vQLQP76YTwY4AuoD4OdNw9egikekyQpXFpgqmTlGjIZXOTd2W5RDZPpRski5N3ADRrLYgLk6QUuvmuT5fWC9acPAYyDU1AVxJcU=@yesql.se>
	<20190327124351.GG12804@msg.df7cb.de>
	<L-956-YkM0DEV1jOI3O32iVnD4I4ZMoqfOPwots1c4Q1dI9jNOn4QSlANcQk2FwJE4Yv_sXIuT5Ty759nITA4BxUq_znsxGrVaC5BTP5buU=@yesql.se>
	<29b364fe-b1f9-5171-6f78-1f01a94244ac@2ndquadrant.com>
	<F0DDA232-983B-44C3-98E1-0DD02746DFDF@yesql.se>
	<3177834d-8313-c641-2d20-f99d69d8b6ff@2ndquadrant.com>
	<3CE32AD0-678E-42A8-A2B1-C2A3EDDE15C7@yesql.se>
	<cd1fdac1-6334-b1b3-f74e-9332178ed0f4@2ndquadrant.com>
	<22906594-DDD7-4085-8318-595C0C9C75C6@yesql.se>

On 23.02.21 17:14, Daniel Gustafsson wrote:
> This exports validate_exec to reduce duplication, and implements a custom
> find_other_exec-like function in pg_upgrade to check each binary for the
> version number.  Keeping a local copy of validate_exec is easy to do if it's
> deemed not worth it to export it.

This looks mostly okay to me.

The commit message says something about "to ensure the health of the 
target cluster", which doesn't make sense to me.  Maybe find a better 
wording.

The name find_exec() seems not very accurate.  It doesn't find anything. 
  Maybe "check"?

I'm not sure why the new find_exec() adds EXE.  AFAIK, this is only 
required for stat(), and validate_exec() already does it.






view thread (25+ messages)  latest in thread

Message-ID: <e048d212-f72e-cff5-36fd-3e867e7d7267@2ndquadrant.com>
Permalink:  ../e048d212-f72e-cff5-36fd-3e867e7d7267@2ndquadrant.com/
Also on:    postgresql.org/message-id/e048d212-f72e-cff5-36fd-3e867e7d7267@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_upgrade version checking questions
  In-Reply-To: <e048d212-f72e-cff5-36fd-3e867e7d7267@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox