pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
To: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: list of extended statistics on psql
Date: Wed, 20 Jan 2021 23:00:50 +0100
Message-ID: <e08cfd09-6803-abd5-2690-0e228c537d37@enterprisedb.com> (raw )
In-Reply-To: <1f609fa9-75a7-b989-c47d-187162d28d52@nttcom.co.jp_1 >
References: <20210107144713.GA8872@alvherre.pgsql >
<29e16ceb-8777-4297-19c8-245242dd7473@enterprisedb.com >
<876efa7e-2067-a4f9-d7e8-f6025440c870@nttcom.co.jp_1 >
<0e84aa72-25f2-1849-753f-f827949132b3@enterprisedb.com >
<85e7e1e7-c2f0-a4a0-61de-6e7ecaee44e3@nttcom.co.jp_1 >
<79d3a4c5-1efe-5b9e-c06e-3a907b531013@nttcom.co.jp_1 >
<20210115084741.GA91293@nol >
<2eb51458-7475-17d3-cb13-b3c950b2f930@enterprisedb.com >
<5e0fb573-3c38-ee39-885c-bdc01f116335@enterprisedb.com >
<TU4PR8401MB115239DC3FE567BE637F7544EEA50@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM >
<d876a1e3-9a6c-712e-7ab8-3dfa8a4cac1e@enterprisedb.com >
<a9c2eb3f-a4e7-b196-9a87-f2acfb5c4859@enterprisedb.com >
<e5268d6a-c361-e017-4eb7-175a2f3fd8fc@nttcom.co.jp_1 >
<39ed9c2f-3698-7a0d-8c67-04f8e9b4439c@enterprisedb.com >
<4948ebb7-0992-8df2-2b14-f84472b46cc5@nttcom.co.jp_1 >
<914705d5-6dc0-817b-9405-891830f43841@enterprisedb.com >
<ce64a900-f3d5-771e-58b5-b52ed0834dea@nttcom.co.jp_1 >
<1f609fa9-75a7-b989-c47d-187162d28d52@nttcom.co.jp_1 >
On 1/20/21 7:41 AM, Tatsuro Yamada wrote:
> Hi Tomas,
>
> On 2021/01/20 11:35, Tatsuro Yamada wrote:
>>> Apologies for all the extra work - I haven't realized this flaw when
>>> pushing for showing more stuff :-(
>>
>> Don't worry about it. We didn't notice the problem even when viewed by
>> multiple
>> people on -hackers. Let's keep moving forward. :-D
>>
>> I'll send a patch including a regression test on the next patch.
>
>
> I created patches and my test results on PG10, 11, 12, and 14 are fine.
>
> 0001:
> - Fix query to use pg_statistic_ext only
> - Replace statuses "required" and "built" with "defined"
> - Remove the size columns
> - Fix document
> - Add schema name as a filter condition on the query
>
> 0002:
> - Fix all results of \dX
> - Add new testcase by non-superuser
>
> Please find attached files. :-D
Thanks, I've pushed this. I had to tweak the regression tests a bit, for
two reasons:
1) to change user in regression tests, don't use \connect, but SET ROLE
and RESET ROLE
2) roles in regression tests should use names with regress_ prefix
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (75+ messages) latest in thread
Message-ID: <e08cfd09-6803-abd5-2690-0e228c537d37@enterprisedb.com>
Permalink: ../e08cfd09-6803-abd5-2690-0e228c537d37@enterprisedb.com/
Also on: postgresql.org/message-id/e08cfd09-6803-abd5-2690-0e228c537d37@enterprisedb.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, tatsuro.yamada.tf@nttcom.co.jp, noriyoshi.shinoda@hpe.com, rjuju123@gmail.com, alvherre@2ndquadrant.com, tomas.vondra@2ndquadrant.com, michael@paquier.xyz, pavel.stehule@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: list of extended statistics on psql
In-Reply-To: <e08cfd09-6803-abd5-2690-0e228c537d37@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox