From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: David G. Johnston <david.g.johnston@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Julien Rouhaud <julien.rouhaud@dalibo.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Typo in insert.sgml
Date: Sun, 27 Aug 2017 21:34:04 -0400
Message-ID: <e133c86c-55ae-0ad6-b25c-1a73cbf888b7@2ndquadrant.com> (raw)
In-Reply-To: <CAKFQuwatuFwvr_61Afdm0S2Kb3VWzH6xqJbxdAacu3t-LS6yig@mail.gmail.com>
References: <20170618071607.GA16418@nol.local>
<8c2b8f00-1a4b-e91d-4d6b-e9add8e9e369@2ndquadrant.com>
<CA+TgmoYYqRy=y61UOFaCJngPO1zx3tuNCGrLNzqwuVHW3k-ntA@mail.gmail.com>
<CAKFQuwatuFwvr_61Afdm0S2Kb3VWzH6xqJbxdAacu3t-LS6yig@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 6/20/17 15:03, David G. Johnston wrote:
> On Tuesday, June 20, 2017, Robert Haas <robertmhaas@gmail.com
> <mailto:robertmhaas@gmail.com>> wrote:
>
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com <javascript:;>> wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
>
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
>
>
> Maybe
>
> [...] that are not identity columns in <literal>tbl2</literal>. Values
> for identity columns will come from the sequence generators for
> <literal>tbl2</literal>.
>
> Otherwise I'd drop the word "continue" altogether and just say "but will
> use the sequence counters for".
I have committed something along those lines.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, david.g.johnston@gmail.com, robertmhaas@gmail.com, julien.rouhaud@dalibo.com
Subject: Re: Typo in insert.sgml
In-Reply-To: <e133c86c-55ae-0ad6-b25c-1a73cbf888b7@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox