public inbox for [email protected]  

help / color / mirror / Atom feed

From: Karl O. Pinc <[email protected]>
To: Tom Lane <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: 'jian he' <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: [PGdocs] fix description for handling pf non-ASCII characters
Date: Tue, 26 Sep 2023 16:50:20 -0500 (CDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <TYAPR01MB586631D0961BF9C44893FAB1F523A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CACJufxFkp8c0ap6YhyXRpVkjsB8pwZjWH9Hqc1tVF0aNWFRzFA@mail.gmail.com>
	<TYAPR01MB58662BC412E1290FC3348973F525A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CACJufxHn1=Phy6E=1PDO0AMXhP1S+XrP5Cioa_rynYpO7gC+=g@mail.gmail.com>
	<TYAPR01MB5866CD2A823B196FBE7F19B9F52EA@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<[email protected]>
	<TYAPR01MB586607D53C42E59DBB00FD9AF5C3A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<[email protected]>
	<[email protected]>

Sep 26, 2023 1:10:55 PM Tom Lane <[email protected]>:

> "Karl O. Pinc" <[email protected]> writes:
>> For the last hunk you'd change around "anything".  Write:
>> "... it will be truncated to less than NAMEDATALEN characters and
>> the bytes of the string which are not printable ASCII characters ...".
>
>> Notice that I have also changed "that" to "which" just above. 
>> I _think_ this is better English.
>
> No, I'm pretty sure you're mistaken.  It's been a long time since
> high school English, but the way I think this works is that "that"
> introduces a restrictive clause, which narrows the scope of what
> you are saying.  That is, you say "that" when you want to talk
> about only the bytes of the string that aren't ASCII.  But "which"
> introduces a non-restrictive clause that adds information or
> commentary.  If you say "bytes of the string which are not ASCII",
> you are effectively making a side assertion that no byte of the
> string is ASCII.  Which is not the meaning you want here.

Makes sense to me.  "That" it is.

Thanks for the help. I never would have figured that out.

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PGdocs] fix description for handling pf non-ASCII characters
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox