From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Daniel Verite <daniel@manitou-mail.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: insensitive collations
Date: Thu, 7 Mar 2019 08:49:55 +0100
Message-ID: <e38166a0-c70d-5b90-a98c-530764cdecb3@2ndquadrant.com> (raw)
In-Reply-To: <02431ac1-37c0-4a06-86e1-bf6cf27881f3@manitou-mail.org>
References: <02431ac1-37c0-4a06-86e1-bf6cf27881f3@manitou-mail.org>
On 2019-03-05 18:48, Daniel Verite wrote:
>> Older ICU versions (<54) don't support all the locale customization
>> options, so many of my new tests in collate.icu.utf8.sql will fail on
>> older systems. What should we do about that? Have another extra test file?
> Maybe stick to the old-style syntax for the regression tests?
> The declarations that won't work as expected with older ICU versions
> would be:
>
> CREATE COLLATION case_insensitive (provider = icu, locale =
> 'und-u-ks-level2', deterministic = false);
>
> 'und-u-ks-level2' is equivalent to 'und@colStrength=secondary'
The problem is not the syntax but that the older ICU versions don't
support the *functionality* of ks-level2 or colStrength=secondary. If
you try it, you will simply get a normal case-sensitive behavior.
It would probably be possible to write all the tests for
nondeterministic collations without making use of this functionality,
using only canonically equivalent sequences as test data. But that
would make the tests extremely weird and unintuitive, so I'd like to
avoid that.
After thinking about it a bit more, I think making a new test file is
reasonable. The file is already fairly long anyway, compared to the
typical test file size.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, daniel@manitou-mail.org, pg@bowt.ie
Subject: Re: insensitive collations
In-Reply-To: <e38166a0-c70d-5b90-a98c-530764cdecb3@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox