public inbox for [email protected]
help / color / mirror / Atom feedFrom: Joel Jacobson <[email protected]>
To: Arseniy Mukhin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
Date: Wed, 20 May 2026 04:20:05 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
References: <[email protected]>
<CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
On Wed, May 20, 2026, at 04:01, Arseniy Mukhin wrote:
> One point - looks like the 0003 contains the same test as 0001.
They are similar, but if you look carefully you'll see that they use
different injection points:
0001 uses async-notify-before-listen-commit
0002 uses async-notify-after-listen-commit
Another different is that if you only apply 0001 and run the tests,
that test will fail without the 0003 fix, whereas 0002 pass both
with and without 0003, since it just tests and demonstrates the
already documented quite harmless false positive race condition.
> Also while I was trying to understand the issue
...
> diagram in the head of the file). It depends on 0001. Your patch fixes
> it too.
OK, I didn't look in detail at untriggered-notification.patch.nocfbot,
but good to hear 0003 fixes it too.
Thanks for reviewing.
/Joel
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox