From: Alexander Lakhin <exclusion@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Fix inconsistencies for v12 (pass 2)
Date: Wed, 12 Jun 2019 17:34:06 +0300
Message-ID: <e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com> (raw)
Hello Amit,
Can you also review the following fixes?:
2.1. bt_binsrch_insert -> _bt_binsrch_insert (an internal inconsistency)
2.2. EWOULDBOCK -> EWOULDBLOCK (a typo)
2.3. FORGET_RELATION_FSYNC & FORGET_DATABASE_FSYNC ->
SYNC_FORGET_REQUEST (orphaned after 3eb77eba)
2.4. GetNewObjectIdWithIndex -> GetNewOidWithIndex (an internal
inconsistency)
2.5. get_opclass_family_and_input_type ->
get_opclass_opfamily_and_input_type (an internal inconsistency)
2.6. HAVE_BUILTIN_CLZ -> HAVE__BUILTIN_CLZ (missing underscore)
2.7. HAVE_BUILTIN_CTZ -> HAVE__BUILTIN_CTZ (missing underscore)
2.8. MultiInsertInfoNextFreeSlot -> CopyMultiInsertInfoNextFreeSlot (an
internal inconsistency)
2.9. targetIsArray -> targetIsSubscripting (an internal inconsistency)
2.10. tss_htup -> remove (orphaned after 2e3da03e)
I can't see another inconsistencies for v12 for now, but there are some
that appeared before.
If this work can be performed more effectively or should be
postponed/canceled, please let me know.
Best regards,
Alexander
Attachments:
[text/x-patch] bt_binsrch_insert.patch (571B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/2-bt_binsrch_insert.patch)
download | inline diff:diff --git a/src/backend/access/nbtree/nbtsearch.c b/src/backend/access/nbtree/nbtsearch.cindex 1f809c24a1..c655dadb96 100644--- a/src/backend/access/nbtree/nbtsearch.c+++ b/src/backend/access/nbtree/nbtsearch.c@@ -424,7 +424,7 @@ _bt_binsrch(Relation rel,
/*
*
- * bt_binsrch_insert() -- Cacheable, incremental leaf page binary search.+ * _bt_binsrch_insert() -- Cacheable, incremental leaf page binary search.
*
* Like _bt_binsrch(), but with support for caching the binary search
* bounds. Only used during insertion, and only on the leaf page that it
[text/x-patch] EWOULDBOCK.patch (544B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/3-EWOULDBOCK.patch)
download | inline diff:diff --git a/src/backend/libpq/be-secure-gssapi.c b/src/backend/libpq/be-secure-gssapi.cindex 1673b10315..ba8c0cd0f0 100644--- a/src/backend/libpq/be-secure-gssapi.c+++ b/src/backend/libpq/be-secure-gssapi.c@@ -400,7 +400,7 @@ read_or_wait(Port *port, ssize_t len)
{
/*
* If we got back less than zero, indicating an error, and that
- * wasn't just a EWOULDBOCK/EAGAIN, then give up.+ * wasn't just a EWOULDBLOCK/EAGAIN, then give up.
*/
if (ret < 0 && !(errno == EWOULDBLOCK || errno == EAGAIN))
return -1;
[text/x-patch] FORGET_RELATION_FSYNC.patch (976B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/4-FORGET_RELATION_FSYNC.patch)
download | inline diff:diff --git a/src/backend/postmaster/checkpointer.c b/src/backend/postmaster/checkpointer.cindex 13f152b473..6ceff63ae1 100644--- a/src/backend/postmaster/checkpointer.c+++ b/src/backend/postmaster/checkpointer.c@@ -1213,8 +1213,8 @@ CompactCheckpointerRequestQueue(void)
* backwards from the end of the queue and check whether a request is
* *preceded* by an earlier, identical request, in the hopes of doing less
* copying. But that might change the semantics, if there's an
- * intervening FORGET_RELATION_FSYNC or FORGET_DATABASE_FSYNC request, so- * we do it this way. It would be possible to be even smarter if we made+ * intervening SYNC_FORGET_REQUEST, so we do it this way.+ * It would be possible to be even smarter if we made
* the code below understand the specific semantics of such requests (it
* could blow away preceding entries that would end up being canceled
* anyhow), but it's not clear that the extra complexity would buy us
[text/x-patch] get_opclass_family_and_input_type.patch (474B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/5-get_opclass_family_and_input_type.patch)
download | inline diff:diff --git a/src/backend/utils/cache/lsyscache.c b/src/backend/utils/cache/lsyscache.cindex b4f2d0f35a..c13c08a97b 100644--- a/src/backend/utils/cache/lsyscache.c+++ b/src/backend/utils/cache/lsyscache.c@@ -1055,7 +1055,7 @@ get_opclass_input_type(Oid opclass)
}
/*
- * get_opclass_family_and_input_type+ * get_opclass_opfamily_and_input_type
*
* Returns the OID of the operator family the opclass belongs to,
* the OID of the datatype the opclass indexes
[text/x-patch] GetNewObjectIdWithIndex.patch (715B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/6-GetNewObjectIdWithIndex.patch)
download | inline diff:diff --git a/src/backend/catalog/catalog.c b/src/backend/catalog/catalog.cindex 11936a6571..a065419cdb 100644--- a/src/backend/catalog/catalog.c+++ b/src/backend/catalog/catalog.c@@ -383,7 +383,7 @@ GetNewOidWithIndex(Relation relation, Oid indexId, AttrNumber oidcolumn)
* is also an unused OID within pg_class. If the result is to be used only
* as a relfilenode for an existing relation, pass NULL for pg_class.
*
- * As with GetNewObjectIdWithIndex(), there is some theoretical risk of a race+ * As with GetNewOidWithIndex(), there is some theoretical risk of a race
* condition, but it doesn't seem worth worrying about.
*
* Note: we don't support using this in bootstrap mode. All relations
[text/x-patch] HAVE_BUILTIN_CLZ.patch (570B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/7-HAVE_BUILTIN_CLZ.patch)
download | inline diff:diff --git a/src/port/pg_bitutils.c b/src/port/pg_bitutils.cindex 60fb55af53..589c2f1615 100644--- a/src/port/pg_bitutils.c+++ b/src/port/pg_bitutils.c@@ -28,7 +28,7 @@
* left-most the 7th bit. The 0th entry of the array should not be used.
*
* Note: this is not used by the functions in pg_bitutils.h when
- * HAVE_BUILTIN_CLZ is defined, but we provide it anyway, so that+ * HAVE__BUILTIN_CLZ is defined, but we provide it anyway, so that
* extensions possibly compiled with a different compiler can use it.
*/
const uint8 pg_leftmost_one_pos[256] = {
[text/x-patch] HAVE_BUILTIN_CTZ.patch (612B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/8-HAVE_BUILTIN_CTZ.patch)
download | inline diff:diff --git a/src/port/pg_bitutils.c b/src/port/pg_bitutils.cindex 60fb55af53..8d9f5be32a 100644--- a/src/port/pg_bitutils.c+++ b/src/port/pg_bitutils.c@@ -56,7 +56,7 @@ const uint8 pg_leftmost_one_pos[256] = {
* left-most the 7th bit. The 0th entry of the array should not be used.
*
* Note: this is not used by the functions in pg_bitutils.h when
- * HAVE_BUILTIN_CTZ is defined, but we provide it anyway, so that+ * HAVE__BUILTIN_CTZ is defined, but we provide it anyway, so that
* extensions possibly compiled with a different compiler can use it.
*/
const uint8 pg_rightmost_one_pos[256] = {
[text/x-patch] MultiInsertInfoNextFreeSlot.patch (540B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/9-MultiInsertInfoNextFreeSlot.patch)
download | inline diff:diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.cindex 84c54fbc70..ac86f3d5be 100644--- a/src/backend/commands/copy.c+++ b/src/backend/commands/copy.c@@ -2626,7 +2626,7 @@ CopyMultiInsertInfoNextFreeSlot(CopyMultiInsertInfo *miinfo,
/*
* Record the previously reserved TupleTableSlot that was reserved by
- * MultiInsertInfoNextFreeSlot as being consumed.+ * CopyMultiInsertInfoNextFreeSlot as being consumed.
*/
static inline void
CopyMultiInsertInfoStore(CopyMultiInsertInfo *miinfo, ResultRelInfo *rri,
[text/x-patch] targetIsArray.patch (582B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/10-targetIsArray.patch)
download | inline diff:diff --git a/src/backend/parser/parse_target.c b/src/backend/parser/parse_target.cindex ef2f5b45d8..ba470366e1 100644--- a/src/backend/parser/parse_target.c+++ b/src/backend/parser/parse_target.c@@ -38,7 +38,7 @@ static void markTargetListOrigin(ParseState *pstate, TargetEntry *tle,
static Node *transformAssignmentIndirection(ParseState *pstate,
Node *basenode,
const char *targetName,
- bool targetIsArray,+ bool targetIsSubscripting,
Oid targetTypeId,
int32 targetTypMod,
Oid targetCollation,
[text/x-patch] tss_htup.patch (371B, ../e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com/11-tss_htup.patch)
download | inline diff:diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.hindex 99b9fa414f..ab985b60c6 100644--- a/src/include/nodes/execnodes.h+++ b/src/include/nodes/execnodes.h@@ -1571,7 +1571,6 @@ typedef struct TidScanState
int tss_NumTids;
int tss_TidPtr;
ItemPointerData *tss_TidList;
- HeapTupleData tss_htup;
} TidScanState;
/* ----------------
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, amit.kapila16@gmail.com
Subject: Re: Fix inconsistencies for v12 (pass 2)
In-Reply-To: <e59e4d46-7c78-afb1-6edc-df77f6d8ccc9@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox