public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Zhang <[email protected]>
To: David G. Johnston <[email protected]>
To: Pavel Luzanov <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql: Add role's membership options to the \du+ command
Date: Wed, 15 Feb 2023 14:52:20 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwYt3ENZoYgY2RBh-U4id_=vntT9uJ83PvxPSsPQ0Cc_Jw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com>

On 2023-02-15 1:37 p.m., David G. Johnston wrote:

> On Wed, Feb 15, 2023 at 2:31 PM David Zhang <[email protected]> wrote:
>
>     There is a default built-in role `pg_monitor` and the behavior
>     changed after the patch. If `\dg+` and `\du+` is treated as the
>     same, and `make check` all pass, then I assume there is no test
>     case to verify the output of `duS+`. My point is should we
>     consider add a test case?
>
> I mean, either you accept the change in how this meta-command presents 
> its information or you don't.  I don't see how a test case is 
> particularly beneficial.  Or, at least the pg_monitor role is not 
> special in this regard.  Alice changed too and you don't seem to be 
> including it in your complaint.
Good improvement, +1.

view thread (9+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: psql: Add role's membership options to the \du+ command
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox