public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Andres Freund <[email protected]>
To: samay sharma <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Nazir Bilal Yavuz <[email protected]>
Cc: John Naylor <[email protected]>
Cc: [email protected]
Subject: Re: Documentation for building with meson
Date: Wed, 12 Apr 2023 23:19:23 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAJxrbyzcMM_TLtUPWkv4R+VSYJEKo-p_fCka1X69V_YHamFhpQ@mail.gmail.com>
	<[email protected]>
	<CAJxrbyyk8jVYCvjyiQ49DOgMzB6skmDgnWjJH_LeA8v__8dOAg@mail.gmail.com>
	<[email protected]>
	<CAJxrbyxYyrJvx2DGogw-6ZD_evyF_iW=6-_0mJAmy-3SqYAewQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAJxrbyx2nw3NvSixGqCfmfYCzQbJkSmUx95uESr9ssWJoyMCtQ@mail.gmail.com>
	<[email protected]>
	<CAJxrbywZDLXga8kz3brvDd81M6QNbTN2DHM5v7uDgSm8=RROEQ@mail.gmail.com>
	<[email protected]>

On 11.04.23 19:18, Andres Freund wrote:
>> Subject: [PATCH v9 2/5] Add data layout options sub-section in installation
>>   docs
>>
>> This commit separates out blocksize, segsize and wal_blocksize
>> options into a separate Data layout options sub-section in both
>> the make and meson docs. They were earlier in a miscellaneous
>> section which included several unrelated options. This change
>> also helps reduce the repetition of the warnings that changing
>> these parameters breaks on-disk compatibility.
> 
> Makes sense. I'm planning to apply this unless Peter or somebody else has
> further feedback.

I'm okay with patches 0001 through 0004.

I don't like 0005.  I think we should drop that for now and maybe have a 
separate discussion under a separate heading about that.

> 
> 
>>  From 11d82aa49efb3d1cbc08f14562a757f115053c8b Mon Sep 17 00:00:00 2001
>> From: Samay Sharma <[email protected]>
>> Date: Mon, 13 Feb 2023 16:23:52 -0800
>> Subject: [PATCH v9 3/5] Remove Anti-Features section from Installation from
>>   source docs
>>
>> Currently, several meson setup options are listed in anti-features.
>> However, they are similar to most other options in the postgres
>> features list as they are 'auto' features themselves. Also, other
>> options are likely better suited to the developer options section.
>> This commit, therefore, moves the options listed in the anti-features
>> section into other sections and removes that section.
>>
>> For consistency, this reorganization has been done on the make section
>> of the docs as well.
> 
> Makes sense to me. "Anti-Features" is confusing as a name to start with.

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Documentation for building with meson
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox