pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Hash support for row types
Date: Tue, 20 Oct 2020 17:10:24 +0200
Message-ID: <e88b1974-5987-9ae8-7e54-7d66f54751cb@2ndquadrant.com> (raw)
In-Reply-To: <20201019233234.r6lyxbvdg5s77rvd@alap3.anarazel.de>
References: <38eccd35-4e2d-6767-1b3c-dada1eac3124@2ndquadrant.com>
	<20201019233234.r6lyxbvdg5s77rvd@alap3.anarazel.de>

On 2020-10-20 01:32, Andres Freund wrote:
> How does this deal with row types with a field that doesn't have a hash
> function? Erroring out at runtime could cause queries that used to
> succeed, e.g. because all fields have btree ops, to fail, if we just have
> a generic unconditionally present hash opclass?  Is that an OK
> "regression"?

Good point.  There is actually code in the type cache that is supposed 
to handle that, so I'll need to adjust that.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (10+ messages)  latest in thread

Message-ID: <e88b1974-5987-9ae8-7e54-7d66f54751cb@2ndquadrant.com>
Permalink:  ../e88b1974-5987-9ae8-7e54-7d66f54751cb@2ndquadrant.com/
Also on:    postgresql.org/message-id/e88b1974-5987-9ae8-7e54-7d66f54751cb@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de
  Subject: Re: Hash support for row types
  In-Reply-To: <e88b1974-5987-9ae8-7e54-7d66f54751cb@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox