public inbox for [email protected]  

help / color / mirror / Atom feed

From: Teodor Sigaev <[email protected]>
To: wenjing zeng <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: CREATE TABLE ( .. STORAGE ..)
Date: Wed, 2 Feb 2022 13:13:29 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Hi!

> Are they both set to name or ColId? Although they are the same.
> 

Thank you, fixed, that was just an oversight.

> 2 For ColumnDef new member storage_name, did you miss the function _copyColumnDef()  _equalColumnDef()?

Thank you, fixed

> 
> 
> Regards
> Wenjing
> 
> 
>> 2021年12月27日 15:51，Teodor Sigaev <[email protected]> 写道：
>>
>> Hi!
>>
>> Working on pluggable toaster (mostly, for JSONB improvements, see links below) I had found that STORAGE attribute on column is impossible to set  in CREATE TABLE command but COMPRESS option is possible. It looks unreasonable. Suggested patch implements this possibility.
>>
>> [1] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfnyc-2021.pdf
>> [2] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgvision-2021.pdf
>> [3] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfonline-2021.pdf
>> [4] http://www.sai.msu.su/~megera/postgres/talks/bytea-pgconfonline-2021.pdf
>>
>> PS I will propose pluggable toaster patch a bit later
>> -- 
>> Teodor Sigaev                      E-mail: [email protected]
>>                                       WWW: http://www.sigaev.ru/<create_table_storage-v1.patch.gz;
> 

-- 
Teodor Sigaev                      E-mail: [email protected]
                                       WWW: http://www.sigaev.ru/

Attachments:

  [application/gzip] create_table_storage-v2.patch.gz (3.9K, ../[email protected]/2-create_table_storage-v2.patch.gz)
  download

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: CREATE TABLE ( .. STORAGE ..)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox