pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Sergei Kornilov <sk@zsrv.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: a.lubennikova@postgrespro.ru <a.lubennikova@postgrespro.ru>
Cc: robertmhaas@gmail.com <robertmhaas@gmail.com>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Cc: andres@anarazel.de <andres@anarazel.de>
Cc: peter.eisentraut@2ndquadrant.com <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Allow some recovery parameters to be changed with reload
Date: Thu, 12 Nov 2020 03:28:06 +0900
Message-ID: <ebba1190-0336-66ef-3023-da6b1f856d82@oss.nttdata.com> (raw)
In-Reply-To: <108021604695421@mail.yandex.ru>
References: <20200809052149.GB17986@paquier.xyz>
	<CA+TgmobB4Syv3rh_v_QoyS=hMpw_Hf4JmjeOFQvDEQA8f2TFGw@mail.gmail.com>
	<1741c40b-73e3-133b-77e6-05ebc7bf3c0f@postgrespro.ru>
	<20201022.110026.524650499365127827.horikyota.ntt@gmail.com>
	<4920201603879284@mail.yandex.ru>
	<0e0d5982-ac64-818d-1ec6-18a80b9300b1@oss.nttdata.com>
	<56311604665173@mail.yandex.ru>
	<a136a397-1401-9531-20c1-1b83575fd68d@oss.nttdata.com>
	<108021604695421@mail.yandex.ru>



On 2020/11/07 6:36, Sergei Kornilov wrote:
> Hello
> 
>> I'm wondering if it's safe to allow restore_command to be emptied during
>> archive recovery. Even when it's emptied, archive recovery can proceed
>> by reading WAL files from pg_wal directory. This is the same behavior as
>> when restore_command is set to, e.g., /bin/false.
> 
> I am always confused by this implementation detail. restore_command fails? Fine, let's just read file from pg_wal. But this is different topic...
> 
> I do not know the history of this fatal ereport. It looks like "must specify restore_command when standby mode is not enabled" check is only intended to protect the user from misconfiguration and the rest code will treat empty restore_command correctly, just like /bin/false.

Maybe.

Anyway, for now I think that your first patch would be enough, i.e.,
just change the context of restore_command to PGC_SIGHUP.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (30+ messages)  latest in thread

Message-ID: <ebba1190-0336-66ef-3023-da6b1f856d82@oss.nttdata.com>
Permalink:  ../ebba1190-0336-66ef-3023-da6b1f856d82@oss.nttdata.com/
Also on:    postgresql.org/message-id/ebba1190-0336-66ef-3023-da6b1f856d82@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, sk@zsrv.org, horikyota.ntt@gmail.com, a.lubennikova@postgrespro.ru, robertmhaas@gmail.com, michael@paquier.xyz, andres@anarazel.de, peter.eisentraut@2ndquadrant.com
  Subject: Re: Allow some recovery parameters to be changed with reload
  In-Reply-To: <ebba1190-0336-66ef-3023-da6b1f856d82@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox