pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Continue work on changes to recovery.conf API
Date: Tue, 27 Nov 2018 09:59:26 +0100
Message-ID: <ec74a8ae-8d25-6d60-1db4-907c7999acbb@2ndquadrant.com> (raw)
In-Reply-To: <20181125203927.f66lvh55ef5aw65g@alap3.anarazel.de>
References: <22e02b05-cd56-6a6b-962d-6d35995827a5@2ndquadrant.com>
	<1876591538256580@iva1-5148b5385b62.qloud-c.yandex.net>
	<943181539360922@iva4-24c534b4e3ac.qloud-c.yandex.net>
	<32159921540906216@myt5-9da6df248f4a.qloud-c.yandex.net>
	<51a6446c-c2b6-b653-c9f5-da38e23ddd9d@2ndquadrant.com>
	<22367601542121030@iva5-d3020dc3459d.qloud-c.yandex.net>
	<2d1877b6-e8cf-a27c-4608-c40758dd0f6c@2ndquadrant.com>
	<20181121060012.GE1951@paquier.xyz>
	<d7f0860c-65d6-5346-c672-3b1116b20ac4@2ndquadrant.com>
	<20181125182415.GP3415@tamriel.snowman.net>
	<20181125203927.f66lvh55ef5aw65g@alap3.anarazel.de>

On 25/11/2018 21:39, Andres Freund wrote:
> On 2018-11-25 13:24:15 -0500, Stephen Frost wrote:
>> - User performs a backup with pg_basebackup -R
>> - Replica is then promoted to be a primary
>> - User performs a backup with pg_basebackup -R on the new primary
>> - Duplicate entries end up in postgresql.auto.conf.  Ew.
> Why don't we put recovery entries into postgresql.recovery.conf or such?
> And overwrite rather than append?

Adding more such sub-configuration files would be easy to do and has
some merit, but the devil is in the details.  In what order would those
files be read?  Who is supposed to write to it, is it reserved for
pg_basebackup use only?  If you choose to use this particular name, is
it not used when not in recovery?  Does this file belong in the data
directory or the configuration directory?  Which choice will offend
packagers the least?  Etc.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (40+ messages)  latest in thread

Message-ID: <ec74a8ae-8d25-6d60-1db4-907c7999acbb@2ndquadrant.com>
Permalink:  ../ec74a8ae-8d25-6d60-1db4-907c7999acbb@2ndquadrant.com/
Also on:    postgresql.org/message-id/ec74a8ae-8d25-6d60-1db4-907c7999acbb@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de, sfrost@snowman.net, michael@paquier.xyz, sk@zsrv.org
  Subject: Re: Continue work on changes to recovery.conf API
  In-Reply-To: <ec74a8ae-8d25-6d60-1db4-907c7999acbb@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox