pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Юрий Соколов <funny.falcon@gmail.com>
Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
Date: Thu, 20 Feb 2020 18:38:22 +0300
Message-ID: <ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru> (raw)
In-Reply-To: <CAH2-Wzk2p_9i7i-s22zVGdJyExaneNCcrwH4BtEDZqr73D6v_A@mail.gmail.com>
References: <55E4051B.7020209@postgrespro.ru>
	<CAH2-WzkFrQ3m5o-nPzgo0Q1_yJjyPyRc77giCzN3fyMaQXk=8g@mail.gmail.com>
	<CAH2-WzmqHsBW6t3TwDRygbzgMJFtukNwNcX9B+w_OrYXbftaPQ@mail.gmail.com>
	<CAH2-WzmDtfc4FpE-tU=5n=k34tUSwOX498GKDcyYj-1G_fQvLQ@mail.gmail.com>
	<CAH2-Wz=HfqHBQBLyrVXLqmE6oGuYE=4tyQAOFRkhOD_ooQqUAw@mail.gmail.com>
	<CAH2-WzkU5B7Rh4LvevfeW5E5tg3YtgO5GVGaU6EEXtxmM2Nshg@mail.gmail.com>
	<5b5a470b-89d7-7177-29c2-2f907f3f441a@iki.fi>
	<CAH2-WzmZGO-NpSCu33tsoZcOskS8UbTUdd7e9V2kJA-kDusWaA@mail.gmail.com>
	<CAH2-Wz=aAMARy08hrzN9UOE4AegsAkge+0nsYk+no2S14W2g2Q@mail.gmail.com>
	<CAH2-Wz=Tr6mxMsKRmv_=9-05_O9QWqOzQ8GweRV2DXS6+Y38QQ@mail.gmail.com>
	<CAH2-Wzme6NA70bkHK=Jrjx+bkHr9DAj9gX+y5OpmvEVNy0eqVQ@mail.gmail.com>
	<CAH2-Wzk42XV2Dg4tYGsLV2X0hf8PSLZ=9gOTOSnp+d6QB_nTyA@mail.gmail.com>
	<CAH2-WzmQGYDDoAETGhpGtJQRv_uFHMjvQZ6JdLV-sxGoCgLBNg@mail.gmail.com>
	<ed6caece-5a64-ad02-2134-1e71fb4b35a1@postgrespro.ru>
	<CAH2-Wzk2p_9i7i-s22zVGdJyExaneNCcrwH4BtEDZqr73D6v_A@mail.gmail.com>

On 19.02.2020 22:16, Peter Geoghegan wrote:
> On Wed, Feb 19, 2020 at 8:14 AM Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> Thank you for this work. I've looked through the patches and they seem
>> to be ready for commit.
>> I haven't yet read recent documentation and readme changes, so maybe
>> I'll send some more feedback tomorrow.

The only thing I found is a typo in the comment

+  int      nhtids;      /* Number of heap TIDs in nhtids array */

s/nhtids/htids

I don't think this patch really needs more nitpicking )

>
>> In my opinion, this message is too specific for default behavior. It
>> exposes internal details without explanation and may look to user like
>> something went wrong.
> You're probably right about that. I just wish that there was some way
> of showing the same information that was discoverable, and didn't
> require the use of pageinspect. If I make it a DEBUG1 message, then it
> cannot really be documented.

User can discover this with a complex query to pg_index and pg_opclass.
To simplify this, we can probably wrap this into function or some field 
in pg_indexes.
Anyway, I would wait for feedback from pre-release testers.






view thread (145+ messages)  latest in thread

Message-ID: <ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru>
Permalink:  ../ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru/
Also on:    postgresql.org/message-id/ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lubennikova@postgrespro.ru, pg@bowt.ie, hlinnaka@iki.fi, pgsql-hackers@lists.postgresql.org, funny.falcon@gmail.com
  Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
  In-Reply-To: <ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox