From: Drouvot, Bertrand <bdrouvot@amazon.com>
To: Julien Rouhaud <rjuju123@gmail.com>
To: bt22kawamotok <bt22kawamotok@oss.nttdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Query Jumbling for CALL and SET utility statements
Date: Tue, 13 Sep 2022 07:30:23 +0200
Message-ID: <ee547cbd-eb0a-28ab-4e71-d3cc8cd77250@amazon.com> (raw)
In-Reply-To: <20220913043316.bjs3mgkgdbx2kixb@jrouhaud>
References: <BBB9A13D-BBE2-44A4-9CA7-6E189120E5A2@amazon.com>
<09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com>
<9aee54f2-5cc1-5b64-1f73-6961932e7bd2@amazon.com>
<Yxl8R8mAUG2vqAcC@paquier.xyz>
<20220908065012.l3bd2np7wj52cxco@jrouhaud>
<c65f1c67-bae4-9658-9206-f11e9c6f7d11@amazon.com>
<20220908112919.2ytxpkitiw6lt2u6@jrouhaud>
<a16d303f-39ad-319c-18ff-85b78b106fe1@amazon.com>
<a0d66747-3f8c-5346-5baa-61299e2cb4da@amazon.com>
<88c16ab86e915ea8a33d3b62522f5537@oss.nttdata.com>
<20220913043316.bjs3mgkgdbx2kixb@jrouhaud>
Hi,
On 9/13/22 6:33 AM, Julien Rouhaud wrote:
> Hi,
>
> On Tue, Sep 13, 2022 at 11:43:52AM +0900, bt22kawamotok wrote:
>> I found that utility statement is counted separately in upper and lower
>> case.
>> For example BEGIN and begin are counted separately.
>> Is it difficult to fix this problem?
> This is a known behavior, utility command aren't normalized (apart from the few
> that will be with this patch) and the queryid is just a hash of the provided
> query string.
>
> It seems unrelated to this patch though. While it can be a bit annoying, it's
> unlikely that the application will have thousands of way to ask for a new
> transaction (mixing case, adding a random number of spaces between BEGIN and
> TRANSACTION and so on), so in real life it won't cause any problem.
Agree that it seems unlikely to cause any problem (as compare to the
utility statements that are handled in this patch).
> Fixing it
> would require to fully jumble all utility statements, which would require a
> separate discussion.
Agree.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, succursale francaise, 31 Place des Corolles, Tour Carpe Diem, F-92400 Courbevoie, SIREN 831 001 334, RCS Nanterre, APE 6311Z, TVA FR30831001334
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bdrouvot@amazon.com, rjuju123@gmail.com, bt22kawamotok@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Query Jumbling for CALL and SET utility statements
In-Reply-To: <ee547cbd-eb0a-28ab-4e71-d3cc8cd77250@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox