public inbox for [email protected]  

help / color / mirror / Atom feed

From: Niyas Sait <[email protected]>
To: Andres Freund <[email protected]>
Cc: Ian Lawrence Barwick <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add native windows on arm64 support
Date: Thu, 1 Dec 2022 17:17:53 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<Yw/9pgS35urJZu/[email protected]>
	<[email protected]>
	<[email protected]>
	<CAB8KJ=jEZZa=2sgtpjq4raTaqh3vxx5GFFKWF=OZFHo6vp0cGg@mail.gmail.com>
	<CAFPTBD8CCT9BNdQQ0QELoo7HPqx26_Zkn0jxg9F9u+bPz-jnEg@mail.gmail.com>
	<[email protected]>


On 05/11/2022 18:31, Andres Freund wrote:
> On 2022-11-03 11:06:46 +0000, Niyas Sait wrote:
>> I've attached a new version of the patch which excludes the already merged
>> ASLR changes and add
>> small changes to handle latest changes in the build scripts.
> Note that we're planning to remove the custom windows build scripts before the
> next release, relying on the meson build instead.
> 

Thanks. I will add changes to add meson build support.

> This won't suffice with the meson build, since the relevant configure test
> also uses arm_acle.h:
> elif host_cpu == 'arm' or host_cpu == 'aarch64'
> 
>   prog = '''
> #include <arm_acle.h>
> 
> int main(void)
> {
>     unsigned int crc = 0;
>     crc = __crc32cb(crc, 0);
>     crc = __crc32ch(crc, 0);
>     crc = __crc32cw(crc, 0);
>     crc = __crc32cd(crc, 0);
> 
>     /* return computed value, to prevent the above being optimized away */
>     return crc == 0;
> }
> '''
> 
>   if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd without -march=armv8-a+crc',
>       args: test_c_args)
>     # Use ARM CRC Extension unconditionally
>     cdata.set('USE_ARMV8_CRC32C', 1)
>     have_optimized_crc = true
>   elif cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd with -march=armv8-a+crc',
>       args: test_c_args + ['-march=armv8-a+crc'])
>     # Use ARM CRC Extension, with runtime check
>     cflags_crc += '-march=armv8-a+crc'
>     cdata.set('USE_ARMV8_CRC32C', false)
>     cdata.set('USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK', 1)
>     have_optimized_crc = true
>   endif
> endif
> 
> The meson checking logic is used both for msvc and other compilers, so this
> will need to work with both.

Yes, will handle that.

-- 
Niyas

view thread (90+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add native windows on arm64 support
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox