pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: adding partitioned tables to publications
Date: Mon, 11 Nov 2019 13:48:57 +0100
Message-ID: <eed6fb07-94d6-a2a5-33e1-84679dca9363@2ndquadrant.com> (raw)
In-Reply-To: <CA+HiwqEQb5-26-=-K=vrWKQhvn7kqOfS-Vgj+H2YMw5XtdUUQw@mail.gmail.com>
References: <CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com>
	<CA+HiwqEF4K+SxBZkU-=q6krGD74ysZZZv5z10_2C=+UcE2vTYw@mail.gmail.com>
	<CA+FpmFf2HVQYRQNh1ZvWPwatyr8_5n4pHRzNtmD5zVqs1zoLbQ@mail.gmail.com>
	<CA+HiwqEgn5da9KvWP4y0rBjcMtHdRao01Lr6TgTw78+UGceJwQ@mail.gmail.com>
	<037d3133-1689-108c-360d-b782e3209cfb@2ndquadrant.com>
	<CA+HiwqHf8_bcyHt=6R4O_Ju4P_Wz6wu1MkOAe14URdpdafS_KQ@mail.gmail.com>
	<CA+HiwqEQb5-26-=-K=vrWKQhvn7kqOfS-Vgj+H2YMw5XtdUUQw@mail.gmail.com>

On 2019-11-11 08:59, Amit Langote wrote:
> On Fri, Nov 8, 2019 at 1:27 PM Amit Langote <amitlangote09@gmail.com> wrote:
>> Anyway, I've attached two patches -- 0001 is a refactoring patch. 0002
>> implements the feature.
> 
> 0002 didn't contain necessary pg_dump changes, which fixed in the
> attached new version.

That looks more pleasant.

I don't understand why you go through great lengths to ensure that the 
relkinds match between publisher and subscriber.  We already ensure that 
only regular tables are published and only regular tables are allowed as 
subscription target.  In the future, we may want to allow further 
combinations.  What situation are you trying to address here?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (86+ messages)  latest in thread

Message-ID: <eed6fb07-94d6-a2a5-33e1-84679dca9363@2ndquadrant.com>
Permalink:  ../eed6fb07-94d6-a2a5-33e1-84679dca9363@2ndquadrant.com/
Also on:    postgresql.org/message-id/eed6fb07-94d6-a2a5-33e1-84679dca9363@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, amitlangote09@gmail.com, rafia.pghackers@gmail.com
  Subject: Re: adding partitioned tables to publications
  In-Reply-To: <eed6fb07-94d6-a2a5-33e1-84679dca9363@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox