public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Robert Haas <[email protected]>
To: Tom Lane <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Jelte Fennema <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Jesse Zhang <[email protected]>
Cc: [email protected]
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Mon, 6 Feb 2023 10:21:07 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoY59Ksso81RNLArNxj0a7xaqV_F_u7gSMHbgdc2kG5Vpw@mail.gmail.com>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
<[email protected]>
<CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CA+TgmoY59Ksso81RNLArNxj0a7xaqV_F_u7gSMHbgdc2kG5Vpw@mail.gmail.com>
On 2023-02-06 Mo 09:40, Robert Haas wrote:
> On Sat, Feb 4, 2023 at 12:37 PM Tom Lane<[email protected]> wrote:
>> But it's not clear to me why you're allergic to the perl wrapper?
>> It's not like that's the only perl infrastructure in our build process.
>> Also, whether or not we could push some of what it does into pg_bsd_indent
>> proper, I can't see pushing all of it (for instance, the very PG-specific
>> list of typedef exclusions).
> I don't mind that there is a script. I do mind that it's not that good
> of a script. There have been some improvements for which I am
> grateful, like removing the thing where the first argument was taken
> as a typedefs file under some circumstances. But there are still some
> things that I would like:
>
> 1. I'd like to be able to run pgindent src/include and have it indent
> everything relevant under src/include. Right now that silently does
> nothing.
>
> 2. I'd like an easy way to indent the unstaged files in the current
> directory (e.g. pgindent --dirty) or the files that have been queued
> up for commit (e.g. pgindent --cached).
>
> 3. I'd also like an easy way to indent every file touched by a recent
> commit, e.g. pgindent --commit HEAD, pgindent --commit HEAD~2,
> pgindent --commit 62e1e28bf7.
Good suggestions. 1 and 3 seem fairly straightforward. I'll start on
those, and look into 2.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (142+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox