public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrei Lepikhov <[email protected]>
To: torikoshia <[email protected]>
To: Rafael Thofehrn Castro <[email protected]>
To: [email protected]
Cc: pgsql-hackers <[email protected]>
Subject: Re: Proposal: Progressive explain
Date: Mon, 31 Mar 2025 08:24:26 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAG0ozMpD27fCyVFoa82G7uV4md4wVYw7DWC-PVA6P5=1v35tsA@mail.gmail.com>
	<CAG0ozMpjEFThDGNqSoFTj1v_cpEs0rRQw5moVKU6Oy88oQ=Yhw@mail.gmail.com>
	<CA+TgmoZ51Hc7o_vFo8rbPqkLpSVzH6i=ccPrt2mHBPyk=zMxwQ@mail.gmail.com>
	<CAG0ozMq48+ODFoLW4HHexN8BKHfh_4c-n2b=yH9oaUnCZNZj6Q@mail.gmail.com>
	<[email protected]>
	<CAG0ozMpPhK1L5eUBq-FJU+uYTPoJ-EPfhPAHpyJvtJpBJHTcvQ@mail.gmail.com>
	<CA+TgmoY0hj+P68iB_JrVMoEV4mbAKthiY2i36ksgFPfU7i80SQ@mail.gmail.com>
	<CAG0ozMo=quwiEfU40n94NGqxB4DydKxNWyeD6U2OX68Z9RhSbg@mail.gmail.com>
	<CA+TgmobGZseEpTeyhzstFs6rVKaB-_CfiC7gTuvz=QhWc=aR=w@mail.gmail.com>
	<CAG0ozMovsrnnLGEM6h0puBr-ihLjYDp11kvnCrnym3D28BZ7eg@mail.gmail.com>
	<CAG0ozMo2HQjmpn9AHGXOo726-PgH=+XmkoPUVxAqvcOS6puq8g@mail.gmail.com>
	<CA+Tgmobjnj0FJj-0GUSXCga3-mUe819Wj=EeZqY=QydMWGOguA@mail.gmail.com>
	<CAG0ozMpug5icxk8Mh_uiGc3OX3zsx67RsRA9Q-o+3ZXn-7M9mQ@mail.gmail.com>
	<[email protected]>

On 3/31/25 02:23, torikoshia wrote:
> On Fri, Mar 7, 2025 at 6:43 AM Rafael Thofehrn Castro 
>> Implemented this version. New patch has the following characteristics:
> 
> 
> I haven't looked into the code yet, but when I ran below commands during 
> make installcheck, there was an error and an assertion failure
> 
>    =# select * from pg_stat_progress_explain;
>    =# \watch 0.1
Yeah, that's to be expected.
I think many corner cases may be found: hash table in the middle of 
filling, opened file descriptors, an incorrect combination of variables, 
  'not yet visited' subtrees - who knows what else? So, last time, I 
just ended up with the idea that using the explain code is a bit 
dangerous - in the middle of execution, it is enough to expose only 
basic data - rows, numbers and timings. It seems safe to gather.

-- 
regards, Andrei Lepikhov





view thread (43+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Proposal: Progressive explain
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox