pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unix-domain socket support on Windows
Date: Mon, 30 Mar 2020 17:43:12 +0200
Message-ID: <efd0338a-35be-d369-a203-51b3ed556064@2ndquadrant.com> (raw)
In-Reply-To: <d4a9e917-b4f3-663c-621c-f83dd2547302@2ndQuadrant.com>
References: <54bde68c-d134-4eb8-5bd3-8af33b72a010@2ndquadrant.com>
	<00d4945e-b437-f3b5-f4af-42e99321c846@2ndquadrant.com>
	<CA+hUKGLkUTNjRZC9e4XjvLQCXL9Dre5ZQhoPqN+rZWbGYV1BQA@mail.gmail.com>
	<fe46da42-00f0-ef1f-ab52-456df58b5bff@2ndquadrant.com>
	<5974caea-1267-7708-40f2-6009a9d653b0@2ndquadrant.com>
	<CAA8=A7-VsWR9Z8Dg0XWTreP_x5=u2cXpGgJymy8-_yesEpHMFg@mail.gmail.com>
	<ce26e70c-cfa6-2f47-5c33-f88bc4d4f288@2ndquadrant.com>
	<75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com>
	<309b8690-7372-355a-ba5e-76094fe8c049@2ndquadrant.com>
	<d4a9e917-b4f3-663c-621c-f83dd2547302@2ndQuadrant.com>

On 2020-03-27 18:52, Andrew Dunstan wrote:
> I have tested this on drongo/fairywren and it works fine. The patches
> apply cleanly (with a bit of fuzz) and a full buildfarm run is happy in
> both cases.
> 
> Unfortunately I don't have a Windows machine that's young enough to
> support git master and old enough not to support Unix Domain sockets, so
> i can't test that with socket-enabled binaries.
> 
> On inspection the patches seem fine.
> 
> Let's commit this and keep working on the pg_upgrade and test issues.

I have committed this in chunks over the last couple of days.  It's done 
now.

I didn't commit the initdb auto-detection patch.  As I mentioned 
earlier, that one is probably not necessary.

Btw., the default AppVeyor images are too old to support this.  You need 
something like 'image: Visual Studio 2019' to get a new enough image. 
So that's one way to test what happens when it's not supported at run 
time.  (I did test it and you get a sensible error message.)

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (22+ messages)

Message-ID: <efd0338a-35be-d369-a203-51b3ed556064@2ndquadrant.com>
Permalink:  ../efd0338a-35be-d369-a203-51b3ed556064@2ndquadrant.com/
Also on:    postgresql.org/message-id/efd0338a-35be-d369-a203-51b3ed556064@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, andrew.dunstan@2ndquadrant.com
  Subject: Re: Unix-domain socket support on Windows
  In-Reply-To: <efd0338a-35be-d369-a203-51b3ed556064@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox