public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pavlo Golub <[email protected]>
To: Sami Imseih <[email protected]>
Cc: Christoph Berg <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
Date: Mon, 30 Mar 2026 16:42:29 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA5RZ0tiUbG5RNK-Es+=R9RGpUkCBeJ_WQA5GzpAD3QiDgS3MA@mail.gmail.com>
References: <CAA5RZ0vMW+0_6FYtFEaN-NAnk1sT2ucCUDJe0-xKwZriROV--A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAA5RZ0sxPWP2xm8fxhscE+cUqC2VSFi9UZ9882BdGZ0MbGQNUA@mail.gmail.com>
	<CAK7ymc+0z7pL-Jub_52JDCyByxK3iYG7KHmudhsjgzF4WGmY0Q@mail.gmail.com>
	<CAA5RZ0sUjsmCNTRHmpOpYNLJ0vbAMc00aJGtCeh6k3YKNw0LQQ@mail.gmail.com>
	<CAK7ymc+Kr7i6p_6Hw_2hEg3xVRH8FYnnrEp0PHg+jeMvqH7mLg@mail.gmail.com>
	<CAA5RZ0tiUbG5RNK-Es+=R9RGpUkCBeJ_WQA5GzpAD3QiDgS3MA@mail.gmail.com>

>
>Here is something I was experimenting with today. I ran 2
>benchmarks; one on HEAD and one with GetCurrentTimestamp()
>added when we are accumulating stats.
>
>"""
>     /* Increment the counts, except when jstate is not NULL */
>     if (!jstate)
>     {
>         Assert(kind == PGSS_PLAN || kind == PGSS_EXEC);
>
>         GetCurrentTimestamp();
>"""
>
>The benchmak script is a series of "SELECT;"
>
># select_tx.sql
>"""
>begin;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>select;
>end;
>"""
>
>The benchmark was on my Ubuntu on EC2 c5a.12xlarge,
>with default pg_stat_statements settings ( no plan tracking
>and top tracking only ).
>
>pgbench command:
>```
>pgbench -c48 -j16 -P1 -f select_tx.sql -T120
>```
>
>Results for 3 runs
>
>## HEAD
>tps = 29351.794589 (without initial connection time)
>tps = 29470.287111 (without initial connection time)
>tps = 29902.245458 (without initial connection time)
>
>## with GetCurrentTimestamp()
>tps = 28569.471891 (without initial connection time)
>tps = 28013.051778 (without initial connection time)
>tps = 28518.468843 (without initial connection time)
>
>I see around 4-5% performance degradation.

Yeah, I can confirm. I have the same degradation on my local 
environment.

Thanks for pointing this out!

I sent a new patch with a new column `last_execution_start`. I hope it 
could make it before freeze. :)
    
https://www.postgresql.org/message-id/em5619eed4-8913-4ee8-a3cd-9f7101b06b6d%40cybertec.at

Best regardsz

view thread (10+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox