public inbox for [email protected]  

help / color / mirror / Atom feed
From: Pavlo Golub <[email protected]>
To: Christoph Berg <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
Date: Fri, 06 Feb 2026 12:57:24 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
	<[email protected]>
	<CAA5RZ0tH_+3JGMCktkp8EMyvKaRAJf-xRh+y_UoZ8azvuUEAYQ@mail.gmail.com>
	<[email protected]>
	<CAK7ymc+E00zKC9Da+BK2se=O2RiOUkdW5dz4iAynD1Vj=Pwexg@mail.gmail.com>
	<CAA5RZ0u_jjiLc_w4nksdVazvvqtE17C1nM=sKf9fy5x02orfsg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

>
>Is this extra complexity worth one saved GetCurrentTimestamp()?

I'm not sure really. But I really need a new column in one way or 
another, so I can agree to whatever decision we'll make.
>
>
>src/backend/access/transam/xact.c is calling GetCurrentTimestamp a
>lot already, so I don't really buy the argument it should be avoided
>at all cost in pg_stat_statements. Just storing the statement end time
>would make this use case much nicer.
+1

Maybe just move GetCurrentTimestamp outside of spin lock is engouh 
already?

>
>
>Christoph






view thread (3+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox