public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pavlo Golub <[email protected]>
To: Sami Imseih <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Christoph Berg <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re[4]: [PATCH] Add last_executed timestamp to pg_stat_statements
Date: Fri, 06 Feb 2026 10:44:58 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA5RZ0u_jjiLc_w4nksdVazvvqtE17C1nM=sKf9fy5x02orfsg@mail.gmail.com>
References: <CAK7ymc+FxoVswo1ok_xDW-xPG-ZEZ8SAqCUkJ7WF04=0aQDvVQ@mail.gmail.com>
	<CAA5RZ0uyvnNuHRj=73jZhocnLxE07oM-AeSLS=FUuuZ_hy7fKA@mail.gmail.com>
	<[email protected]>
	<CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
	<[email protected]>
	<CAA5RZ0tH_+3JGMCktkp8EMyvKaRAJf-xRh+y_UoZ8azvuUEAYQ@mail.gmail.com>
	<[email protected]>
	<CAK7ymc+E00zKC9Da+BK2se=O2RiOUkdW5dz4iAynD1Vj=Pwexg@mail.gmail.com>
	<CAA5RZ0u_jjiLc_w4nksdVazvvqtE17C1nM=sKf9fy5x02orfsg@mail.gmail.com>

Hey

>>  Thank you to Sami, Christoph, and Bertrand for the thorough review and valuable
>>  feedback on v1. I've prepared a v2 patch that addresses all the concerns raised.
>
>Thanks for the patch! I have not looked at v2 in detail yet. Did take
>a quick peek
>at the doc. Some comments:
>
>>  I've renamed the column to `stats_last_updated` as Christoph suggested. This
>>  matches the existing "stats_since" column for consistency. Following Christoph's
>>  suggestion, I've also moved it to the end of the view.
>
>I still wonder if "stats_last_updated" is a good name here. What about
>"last_execution_start", since that is exactly what this timestamp is.

Yeah, sounds better really. Thanks

>
>
>+ <entry role="catalog_table_entry"><para role="column_definition">
>+ <structfield>stats_last_updated</structfield> <type>timestamp with
>time zone</type>
>+ </para>
>+ <para>
>+ Time at which the statement statistics were last updated (specifically,
>+ the time when the statement most recently started execution).
>
>Here I think we can just say:
>
>"The start time of the most recent execution of the statement that completed. "

+1

>
>
>+ This is useful for monitoring tools to identify which statements
>+ have been executed since their last poll.
>
>I am not sure we need this part for the docs. others may disagree.

Agree, too much details.

>
>
>+ For nested statements (when <varname>pg_stat_statements.track</varname>
>+ is set to <literal>all</literal>), this reflects the start time of the
>+ parent top-level statement.
>+ </para></entry>
>
>Maybe this is better as it mentioned "toplevel"
>
>"For nested statements (toplevel = false), this reflects the start time
>of the top-level statement."

I like it. Looks easier to read.

>
>
>what do you think?

Thanks, I'll prepare updated patch
>
>
>--
>Sami Imseih
>Amazon Web Services (AWS)

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Re[4]: [PATCH] Add last_executed timestamp to pg_stat_statements
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox