pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Sehrope Sarkuni <sehrope@jackdb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: fsync error handling in pg_receivewal, pg_recvlogical
Date: Mon, 29 Jul 2019 08:06:48 +0200
Message-ID: <f04eeadf-3b0b-346f-c13c-702ce2670142@2ndquadrant.com> (raw)
In-Reply-To: <CAH7T-arrc8KQyKUQYpGYL6XaDH-oA7x=+nCUJDZbgfq6Y7P9BQ@mail.gmail.com>
References: <9b49fe44-8f3e-eca9-5914-29e9e99030bf@2ndquadrant.com>
	<20190329130505.GG1954@paquier.xyz>
	<43bba31e-c520-2de0-1b02-5672bc7faf70@2ndquadrant.com>
	<20190626041131.GI1714@paquier.xyz>
	<CAH7T-arrc8KQyKUQYpGYL6XaDH-oA7x=+nCUJDZbgfq6Y7P9BQ@mail.gmail.com>

On 2019-07-27 19:02, Sehrope Sarkuni wrote:
> Tried out this patch and it applies, compiles, and passes check-world.
> Also flipped things around in pg_recvlogical.c to exit-on-success to
> ensure it's actually being called and that worked too. Outside of a more
> complicated harness that simulates fsync errors not sure how else to
> test this further.

I have committed this, with the exit code changed back, as requested by
Michael.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (8+ messages)

Message-ID: <f04eeadf-3b0b-346f-c13c-702ce2670142@2ndquadrant.com>
Permalink:  ../f04eeadf-3b0b-346f-c13c-702ce2670142@2ndquadrant.com/
Also on:    postgresql.org/message-id/f04eeadf-3b0b-346f-c13c-702ce2670142@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, sehrope@jackdb.com, michael@paquier.xyz
  Subject: Re: fsync error handling in pg_receivewal, pg_recvlogical
  In-Reply-To: <f04eeadf-3b0b-346f-c13c-702ce2670142@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox