public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tomas Vondra <[email protected]>
To: Matthias van de Meent <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Parallel CREATE INDEX for BRIN indexes
Date: Sun, 12 Nov 2023 11:01:39 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEze2WieBtuOOepjA8cr8VhAiQfeZjcFQVy7p_HHPSEu1QSoMg@mail.gmail.com>
References: <[email protected]>
	<CAEze2WgPH4zdEcULR_N4DwDa3B6NdU--577N0RuP5463HB6K5g@mail.gmail.com>
	<[email protected]>
	<CAEze2Whg43uK9g3CT_qWxWa2PjtcOU_eqTuxjBOOfNuzsPGAMA@mail.gmail.com>
	<[email protected]>
	<CAEze2WgJrU61Q12Q4UO0Xcgk1DdTegXss=r3uX1UabiMVT-8gg@mail.gmail.com>
	<[email protected]>
	<CAEze2Wgb+V1AbYueaJ6zMEEBwCMMRsbnQDn-iXV5fXN1JTFQpA@mail.gmail.com>
	<[email protected]>
	<CAEze2WieBtuOOepjA8cr8VhAiQfeZjcFQVy7p_HHPSEu1QSoMg@mail.gmail.com>



On 11/12/23 10:38, Matthias van de Meent wrote:
> On Wed, 8 Nov 2023 at 12:03, Tomas Vondra <[email protected]> wrote:
>>
>> Hi,
>>
>> here's an updated patch, addressing the review comments, and reworking
>> how the work is divided between the workers & leader etc.
> 
> Thanks!
> 
>> In general I'm quite happy with the current state, and I believe it's
>> fairly close to be committable.
> 
> Are you planning on committing the patches separately, or squashed? I
> won't have much time this week for reviewing the patch, and it seems
> like these patches are incremental, so some guidance on what you want
> to be reviewed would be appreciated.
> 

Definitely squashed. I only kept them separate to make it more obvious
what the changes are.

If you need more time for a review, I can certainly wait. No rush.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Parallel CREATE INDEX for BRIN indexes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox