public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: SATYANARAYANA NARLAPURAM <[email protected]>
To: Ashutosh Bapat <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Bug: pg_get_viewdef() fails on GRAPH_TABLE views with lateral column references
Date: Fri, 24 Apr 2026 09:18:12 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHg+QDe2=EzNGraOnEMX6G2PYLp599JBXMMJT4gw6tJfFAsXcg@mail.gmail.com>
References: <CAHg+QDcLVa2iBnggkHxY4itZbXtDMfsYHEjnCUYe9hNbnxDi-w@mail.gmail.com>
	<CAExHW5tOhqm7U0Yvsj=aEQWefKnD-ijpT2YzCCrDNJYm=QQu2Q@mail.gmail.com>
	<CAHg+QDe2=EzNGraOnEMX6G2PYLp599JBXMMJT4gw6tJfFAsXcg@mail.gmail.com>

On 21.04.26 10:02, SATYANARAYANA NARLAPURAM wrote:
>     The code doesn't explain why it adds the dummy context but it seemed
>     intentional. But it's not used at other places like deparsing WHERE
>     clause in element patterns or that in the graph_table itself. Since a
>     lateral reference is allowed in COLUMNS clause as well, it doesn't
>     make sense not to pass a context with lateral namespaces. Also there
>     is no comment explaining the dummy context. So your fix looks good to
>     me. I adjusted the surrounding code a bit.
> 
>     I adjusted an existing view for the testing instead of adding a new
>     one with all the additional objects. Since that view definition was
>     getting more complex, I formatted the DDL to be more readable.
> 
>     I also think that we should use prettyFlags to deparse all GRAPH_TABLE
>     components in a human readable form. But that's out of the scope for
>     this patch.
> 
>     PFA updated patch.
> 
> Thank you for updating the patch. It applies cleanly and the related 
> tests are passing.

committed

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bug: pg_get_viewdef() fails on GRAPH_TABLE views with lateral column references
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox