From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Date: Fri, 10 Aug 2018 13:39:49 +0300
Message-ID: <f3a111b1dae1dd18afa14101736a0e0f@postgrespro.ru> (raw)
In-Reply-To: <alpine.DEB.2.21.1808101027390.9120@lancre>
References: <20180508193621.dphlgwrd5yz67o2z@alvherre.pgsql>
<0569c5309cf536a839e2a3a1433bd113@postgrespro.ru>
<alpine.DEB.2.21.1807091451520.17811@lancre>
<a6299efa310e1d106144f761259f4fd6@postgrespro.ru>
<alpine.DEB.2.21.1807111435250.27883@lancre>
<976a25a46420c93866ada4051976b1be@postgrespro.ru>
<alpine.DEB.2.21.1807112124210.27883@lancre>
<f153ffd55f481d714ee44afc99ecc67e@postgrespro.ru>
<alpine.DEB.2.21.1807121801250.27883@lancre>
<25d7b1f518c218a8c335bdfc6c858ea1@postgrespro.ru>
<alpine.DEB.2.21.1808071823540.13466@lancre>
<fcc2512cdc9e6bc49d3b489181f454da@postgrespro.ru>
<alpine.DEB.2.21.1808101027390.9120@lancre>
On 10-08-2018 11:33, Fabien COELHO wrote:
> Hello Marina,
>
>>> I'd suggest to let lookupCreateVariable, putVariable* as they are,
>>> call pgbench_error with a level which does not stop the execution,
>>> and
>>> abort if necessary from the callers with a "aborted because of
>>> putVariable/eval/... error" message, as it was done before.
>>
>> There's one more problem: if this is a client failure, an error
>> message inside any of these functions should be printed at the level
>> DEBUG_FAILS; otherwise it should be printed at the level LOG. Or do
>> you suggest using the error level as an argument for these functions?
>
> No. I suggest that the called function does only one simple thing,
> probably "DEBUG", and that the *caller* prints a message if it is
> unhappy about the failure of the called function, as it is currently
> done. This allows to provide context as well from the caller, eg
> "setting variable %s failed while <some specific context>". The user
> call rerun under debug for precision if they need it.
Ok!
> I'm still not over enthousiastic with these changes, and still think
> that it should be an independent patch, not submitted together with
> the "retry on error" feature.
In the next version I will put the error patch last, so it will be
possible to compare the "retry on error" feature with it and without it,
and let the committer decide how it is better)
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: m.polyakova@postgrespro.ru, coelho@cri.ensmp.fr, alvherre@2ndquadrant.com, i.kurbangaliev@postgrespro.ru, teodor@sigaev.ru
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
In-Reply-To: <f3a111b1dae1dd18afa14101736a0e0f@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox