public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Steele <[email protected]>
To: Stephen Frost <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Chapman Flack <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: [email protected]
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date: Tue, 5 Apr 2022 12:06:08 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<20220310000622.GA225595@nathanxps13>
	<[email protected]>
	<20220311003834.GA597706@nathanxps13>
	<[email protected]>
	<20220329020948.GA311150@nathanxps13>
	<[email protected]>
	<20220404142247.GA663209@nathanxps13>
	<20220404154218.GA792581@nathanxps13>
	<[email protected]>
	<[email protected]>

On 4/5/22 11:25 AM, Stephen Frost wrote:
> 
> Please find attached an updated patch + commit message.  Mostly, I just
> went through and did a bit more in terms of updating the documentation
> and improving the comments (there were some places that were still
> worrying about the chance of a 'stray' backup_label file existing, which
> isn't possible any longer), along with some additional testing and
> review.  This is looking pretty good to me, but other thoughts are
> certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.

I have reviewed the changes and they look good. I also ran the new patch 
through pgbackrest regression with no issues.

Regards,
-- 
-David
[email protected]

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox