pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: pgsql-hackers@postgresql.org
Subject: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
Date: Mon, 17 May 2021 23:29:18 +0900
Message-ID: <f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com> (raw)

If a promotion is triggered while recovery is paused, the paused state ends
and promotion continues. But currently pg_get_wal_replay_pause_state()
returns 'paused' in that case. Isn't this a bug?

Attached patch fixes this issue by resetting the recovery pause state to
'not paused' when standby promotion is triggered.

Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachments:

reset_wal_pause_state_after_promotion_v1.patch (text/plain, 693B) download
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 8d163f190f..441a9124cd 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -12825,6 +12825,14 @@ SetPromoteIsTriggered(void)
 	XLogCtl->SharedPromoteIsTriggered = true;
 	SpinLockRelease(&XLogCtl->info_lck);
 
+	/*
+	 * Mark the recovery pause state as 'not paused' because the paused state
+	 * ends and promotion continues if a promotion is triggered while recovery
+	 * is paused. Otherwise pg_get_wal_replay_pause_state() can mistakenly
+	 * return 'paused' while a promotion is ongoing.
+	 */
+	SetRecoveryPause(false);
+
 	LocalPromoteIsTriggered = true;
 }
 

view thread (20+ messages)  latest in thread

Message-ID: <f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com>
Permalink:  ../f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com/
Also on:    postgresql.org/message-id/f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com
  Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
  In-Reply-To: <f706876c-4894-0ba5-6f4d-79803eeea21b@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox