From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: using explicit_bzero
Date: Tue, 17 Sep 2019 11:10:16 +0200
Message-ID: <f7b5f301-b128-9269-fe1c-269a7cc0c257@2ndquadrant.com> (raw)
In-Reply-To: <20190909151845.acjtzqatc4je7pfc@alap3.anarazel.de>
References: <693b191e-f2af-8d3d-39e5-c6c87c1b026a@2ndquadrant.com>
<20190904203821.GA12725@alvherre.pgsql>
<20190905021213.GB22147@paquier.xyz>
<eeeba5c2-af76-fcb5-efba-399ec1657986@2ndquadrant.com>
<20190909151845.acjtzqatc4je7pfc@alap3.anarazel.de>
On 2019-09-09 17:18, Andres Freund wrote:
> I think all this implementation actually guarantees is that bzero2 is
> read, but not that the copy is not elided. In practice that's *probably*
> good enough, but a compiler could just check whether bzero_p points to
> memset.
Are you saying that the replacement implementation we provide is not
good enough? If so, I'm happy to look at alternatives. But that's the
design from OpenSSH, so if that is wrong, then there are bigger
problems. We could also take the OpenBSD implementation, but that has a
GCC-ish dependency, so we would probably want the OpenSSH implementation
as a fallback anyway.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: using explicit_bzero
In-Reply-To: <f7b5f301-b128-9269-fe1c-269a7cc0c257@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox