From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: kuroda.hayato@fujitsu.com <kuroda.hayato@fujitsu.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: Shinya11.Kato@oss.nttdata.com <Shinya11.Kato@oss.nttdata.com>
Cc: zyu@yugabyte.com <zyu@yugabyte.com>
Subject: Re: [Proposal] Add foreign-server health checks infrastructure
Date: Fri, 18 Feb 2022 17:59:46 +0900
Message-ID: <f9a4ebb5-9484-30a4-1eff-bb89d79e57bb@oss.nttdata.com> (raw)
In-Reply-To: <TYAPR01MB586604332882FCCCF784A5B1F5369@TYAPR01MB5866.jpnprd01.prod.outlook.com>
References: <20220216.115058.1615761004338301624.horikyota.ntt@gmail.com>
<TYAPR01MB58661B088B6066282824ADD9F5369@TYAPR01MB5866.jpnprd01.prod.outlook.com>
<TYAPR01MB58664ABD1AC9F42904017461F5369@TYAPR01MB5866.jpnprd01.prod.outlook.com>
<20220217.171405.1911593760090019851.horikyota.ntt@gmail.com>
<TYAPR01MB586604332882FCCCF784A5B1F5369@TYAPR01MB5866.jpnprd01.prod.outlook.com>
On 2022/02/17 19:35, kuroda.hayato@fujitsu.com wrote:
> Dear Horiguchi-san,
>
>> I think we just don't need to add the special timeout kind to the
>> core. postgres_fdw can use USER_TIMEOUT and it would be suffiction to
>> keep running health checking regardless of transaction state then fire
>> query cancel if disconnection happens. As I said in the previous main,
>> possible extra query cancel woud be safe.
Sounds reasonable to me.
> I finally figured out that you mentioned about user-defined timeout system.
> Firstly - before posting to hackers - I designed like that,
> but I was afraid of an overhead that many FDW registers timeout
> and call setitimer() many times. Is it too overcautious?
Isn't it a very special case where many FDWs use their own user timeouts? Could you tell me the assumption that you're thinking, especially how many FDWs are working?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, kuroda.hayato@fujitsu.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org, Shinya11.Kato@oss.nttdata.com, zyu@yugabyte.com
Subject: Re: [Proposal] Add foreign-server health checks infrastructure
In-Reply-To: <f9a4ebb5-9484-30a4-1eff-bb89d79e57bb@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox