public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jim Jones <[email protected]>
To: Carlos Alves <[email protected]>
To: [email protected]
Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE
Date: Thu, 26 Mar 2026 19:12:04 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <177454798496.946.17517925915684610719.pgcf@coridan.postgresql.org>
References: <[email protected]>
	<CAL-Pge6dUj7gEdd74aPjvxmPkgjMXMF2kp3hDh75eQCPmsBeZQ@mail.gmail.com>
	<177454798496.946.17517925915684610719.pgcf@coridan.postgresql.org>

Hi Carlos

On 26/03/2026 18:59, Carlos Alves wrote:
> No errors or failures were detected during the tests.
> 
> The only suggestion is to keep the parameter description a single paragraph, following the same style as the description of the other inclusion parameters. But the current description is coherent and okay.
> 
> After the tests, the patch is working as expected:
> - Table-level comments are copied when the `including comments` parameter is used.
> - When there is more than one source table, comments, if any, are kept in the order in which they appear in the command, separated by a new line.
> - The performance of command execution was not affected.
> 
> I think only the code review is missing, but I don't have much experience to perform this step.


Thanks for this thorough review. This helps a lot!
Let's see what the other reviewers have to say about the code and your
docs suggestion.

Best, Jim

view thread (18+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox