pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jacob Champion <pchampion@vmware.com>
To: john.naylor@enterprisedb.com <john.naylor@enterprisedb.com>
Cc: pavel.stehule@gmail.com <pavel.stehule@gmail.com>
Cc: laurenz.albe@cybertec.at <laurenz.albe@cybertec.at>
Cc: horikyota.ntt@gmail.com <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: peter.eisentraut@enterprisedb.com <peter.eisentraut@enterprisedb.com>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: badly calculated width of emoji in psql
Date: Thu, 26 Aug 2021 15:25:22 +0000
Message-ID: <fa68be752004b6d05fc72bac0d7c489f4abba4b3.camel@vmware.com> (raw)
In-Reply-To: <CAFBsxsH5ejH4-1xaTLpSK8vWoK1m6fA1JBtTM6jmBsLfmDki1g@mail.gmail.com>
References: <9e3c847108bac6041f50e86d08d8835f5cf7cd78.camel@vmware.com>
	<YPUtzT0J8cZByTkD@paquier.xyz>
	<f6a06ecdf378b50ed871e363aa9ac7e706101ab6.camel@cybertec.at>
	<c2a556a0158b642d6c597508d2a47059091e4d56.camel@vmware.com>
	<2f7ca10c7847f69267685beca7b5aa92dd876259.camel@vmware.com>
	<CAFj8pRCuaHgxa8M_FxmhGDg46qWp4yF-Xz_Xkj5NZT-F9fkQ1w@mail.gmail.com>
	<CAFBsxsEW0oAD2gdWQ9OQ8dS52iz476kWK2pqV1xmGuVjaygZTA@mail.gmail.com>
	<bedc833c3f60bbcd72ce613fc6a677be609d19dd.camel@vmware.com>
	<CAFBsxsGZTwzDnTs=TVM38CCTPP3Y0D3=h+UiWt8M83D5THHf9A@mail.gmail.com>
	<CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com>
	<YRnRFIe5ycU3GYaX@paquier.xyz>
	<CAFBsxsG39ZQNKDQpE3Yu6rytemsCk8naJ9ib=WyiSUia24_3qw@mail.gmail.com>
	<CAFBsxsEX8+K4fvvUEJYTqbhpj9ENenWwYm9SrMXZ1P2cPG8P+Q@mail.gmail.com>
	<39db2e88a680c5c0c113eb1977db90fa19f97155.camel@vmware.com>
	<CAFBsxsGOCpzV7c-f3a8ADsA1n4uZ=8puCctQp+x7W0vgkv=w+g@mail.gmail.com>
	<b51c5abaf17a46bf82027cd833cfc91ab6d45aad.camel@vmware.com>
	<CAFBsxsH5ejH4-1xaTLpSK8vWoK1m6fA1JBtTM6jmBsLfmDki1g@mail.gmail.com>

On Wed, 2021-08-25 at 16:15 -0400, John Naylor wrote:
> On Tue, Aug 24, 2021 at 1:50 PM Jacob Champion <pchampion@vmware.com> wrote:
> >
> > Does there need to be any sanity check for overlapping ranges between
> > the combining and fullwidth sets? The Unicode data on a dev's machine
> > would have to be broken somehow for that to happen, but it could
> > potentially go undetected for a while if it did.
> 
> It turns out I should have done that to begin with. In the Unicode
> data, it apparently happens that a character can be both combining
> and wide, and that will cause ranges to overlap in my scheme:

I was looking for overlaps in my review, but I skipped right over that,
sorry...

On Thu, 2021-08-26 at 11:12 -0400, John Naylor wrote:
> I pushed Jacob's patch with the addendum I shared upthread, plus a
> comment about search order. I also took the liberty of changing the
> author in the CF app to Jacob. Later I'll push detecting non-spacing
> characters beyond the BMP.

Thanks!

--Jacob


view thread (37+ messages)  latest in thread

Message-ID: <fa68be752004b6d05fc72bac0d7c489f4abba4b3.camel@vmware.com>
Permalink:  ../fa68be752004b6d05fc72bac0d7c489f4abba4b3.camel@vmware.com/
Also on:    postgresql.org/message-id/fa68be752004b6d05fc72bac0d7c489f4abba4b3.camel@vmware.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pchampion@vmware.com, john.naylor@enterprisedb.com, pavel.stehule@gmail.com, laurenz.albe@cybertec.at, horikyota.ntt@gmail.com, peter.eisentraut@enterprisedb.com, michael@paquier.xyz
  Subject: Re: badly calculated width of emoji in psql
  In-Reply-To: <fa68be752004b6d05fc72bac0d7c489f4abba4b3.camel@vmware.com>
  References: <9e3c847108bac6041f50e86d08d8835f5cf7cd78.camel@vmware.com> <2f7ca10c7847f69267685beca7b5aa92dd876259.camel@vmware.com> <CAFj8pRCuaHgxa8M_FxmhGDg46qWp4yF-Xz_Xkj5NZT-F9fkQ1w@mail.gmail.com> <CAFBsxsEW0oAD2gdWQ9OQ8dS52iz476kWK2pqV1xmGuVjaygZTA@mail.gmail.com> <bedc833c3f60bbcd72ce613fc6a677be609d19dd.camel@vmware.com> <CAFBsxsGZTwzDnTs=TVM38CCTPP3Y0D3=h+UiWt8M83D5THHf9A@mail.gmail.com> <CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com> <YRnRFIe5ycU3GYaX@paquier.xyz> <CAFBsxsG39ZQNKDQpE3Yu6rytemsCk8naJ9ib=WyiSUia24_3qw@mail.gmail.com> <CAFBsxsEX8+K4fvvUEJYTqbhpj9ENenWwYm9SrMXZ1P2cPG8P+Q@mail.gmail.com> <39db2e88a680c5c0c113eb1977db90fa19f97155.camel@vmware.com> <CAFBsxsGOCpzV7c-f3a8ADsA1n4uZ=8puCctQp+x7W0vgkv=w+g@mail.gmail.com> <b51c5abaf17a46bf82027cd833cfc91ab6d45aad.camel@vmware.com> <CAFBsxsH5ejH4-1xaTLpSK8vWoK1m6fA1JBtTM6jmBsLfmDki1g@mail.gmail.com> <fa68be752004b6d05fc72bac0d7c489f4abba4b3.camel@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox