pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Pre-proposal: unicode normalized text
Date: Fri, 03 Nov 2023 00:49:37 -0700
Message-ID: <fac5bcd6dfca06f32a9690d22dee247326e21e0d.camel@j-davis.com> (raw)
In-Reply-To: <CA+hUKGLEovzm-r_usy=CxXf4ffGXMYKkMnz9Do7ismxww_g--g@mail.gmail.com>
References: <f30b58657ceb71d5be032decf4058d454cc1df74.camel@j-davis.com>
	<33a31c45-2e80-1270-771a-b75f3920a5ec@eisentraut.org>
	<CA+TgmoYHEv_-rsSbpfbByUVr6_VVW-mDghfEK3oTcvvEm+0NYQ@mail.gmail.com>
	<3941663a8e2f185d6acbbbc4f172c41dd3cfb6fe.camel@j-davis.com>
	<CA+TgmoYzYR-yhU6k1XFCADeyj=Oyz2PkVsa3iKv+keM8wp-F_A@mail.gmail.com>
	<96c0173c5156d365e132ec29e4873237be565743.camel@j-davis.com>
	<fe5d9163-462b-4da3-a87e-b0247df0081b@eisentraut.org>
	<CA+TgmoaJoECzK-rzMBmMktBfEVMAfLmtG8PdmHfq2UYRoHvsmg@mail.gmail.com>
	<2bab90239c5264fa9a87372c16bbf8759c8f9e64.camel@j-davis.com>
	<6c78e772-0c1b-4a8f-ab14-d673a086d35e@eisentraut.org>
	<c5e9dac884332824e0797937518da0b8766c1238.camel@j-davis.com>
	<85329793af3fd24fd331a0a3b29b0e4784e767a4.camel@j-davis.com>
	<CA+hUKGLEovzm-r_usy=CxXf4ffGXMYKkMnz9Do7ismxww_g--g@mail.gmail.com>

On Fri, 2023-11-03 at 10:51 +1300, Thomas Munro wrote:
> bowerbird and hammerkop didn't like commit a02b37fc.  They're still
> using the old 3rd build system that is not tested by CI.  It's due
> for
> removal in the 17 cycle IIUC but in the meantime I guess the new
> codegen script needs to be invoked by something under src/tools/msvc?
> 
>   varlena.obj : error LNK2019: unresolved external symbol
> unicode_category referenced in function unicode_assigned
> [H:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj]

I think I just need to add unicode_category.c to @pgcommonallfiles in
Mkvcbuild.pm. I'll do a trial commit tomorrow and see if that fixes it
unless someone has a better suggestion.

Regards,
	Jeff Davis






view thread (77+ messages)  latest in thread

Message-ID: <fac5bcd6dfca06f32a9690d22dee247326e21e0d.camel@j-davis.com>
Permalink:  ../fac5bcd6dfca06f32a9690d22dee247326e21e0d.camel@j-davis.com/
Also on:    postgresql.org/message-id/fac5bcd6dfca06f32a9690d22dee247326e21e0d.camel@j-davis.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, thomas.munro@gmail.com, peter@eisentraut.org, robertmhaas@gmail.com
  Subject: Re: Pre-proposal: unicode normalized text
  In-Reply-To: <fac5bcd6dfca06f32a9690d22dee247326e21e0d.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox