From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Andrey Klychkov <aaklychkov@mail.ru>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Victor Yegorov <vyegorov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Alter index rename concurrently to
Date: Thu, 18 Oct 2018 00:11:51 +0200
Message-ID: <fbf5f80c-b45b-43c6-3b31-7a408cc9501c@2ndquadrant.com> (raw)
In-Reply-To: <20181013020131.waeojm6anbs4mavy@alap3.anarazel.de>
References: <1531767486.432607658@f357.i.mail.ru>
<c3d9a44c-2ca1-6726-ad03-ed9c37cc7c29@2ndquadrant.com>
<8cba25b5-e7c7-de36-7886-5488b37ec521@2ndquadrant.com>
<1538567488.953452852@f403.i.mail.ru>
<aa4b16af-5cca-ded6-f5fa-1a0dadcf5906@2ndquadrant.com>
<20181013020131.waeojm6anbs4mavy@alap3.anarazel.de>
On 13/10/2018 04:01, Andres Freund wrote:
> I don't see how this could be argued. It has to be a self-conflicting
> lockmode, otherwise you'd end up doing renames of tables where you
> cannot see the previous state. And you'd get weird errors about updating
> invisible rows etc.
> I don't buy this description. Imo it's a fundamental correctness
> thing. Without it concurrent DDL would potentially overwrite the rename,
> because they could start updating while still seeing the old version.
OK, I can refine those descriptions/comments. Do you have any concerns
about the underlying principle of this patch?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de, aaklychkov@mail.ru, robertmhaas@gmail.com, vyegorov@gmail.com
Subject: Re: Alter index rename concurrently to
In-Reply-To: <fbf5f80c-b45b-43c6-3b31-7a408cc9501c@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox