public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Daniel Gustafsson <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Reducing connection overhead in pg_upgrade compat check phase
Date: Wed, 13 Sep 2023 16:12:02 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<20230313182147.GA294021@nathanxps13>
	<20230704190839.GA3468243@nathanxps13>
	<[email protected]>
	<20230708214354.GA4044380@nathanxps13>
	<[email protected]>
	<20230710230907.GA481155@nathanxps13>
	<[email protected]>
	<[email protected]>
	<20230711233606.GA776188@nathanxps13>
	<[email protected]>

On 31.08.23 23:34, Daniel Gustafsson wrote:
>> On 12 Jul 2023, at 01:36, Nathan Bossart <[email protected]> wrote:
>>
>> On Wed, Jul 12, 2023 at 12:43:14AM +0200, Daniel Gustafsson wrote:
>>> I did have coffee before now, but only found time to actually address this now
>>> so here is a v7 with just that change and a fresh rebase.
>>
>> Thanks.  I think the patch is in decent shape.
> 
> Due to ENOTENOUGHTIME it bitrotted a bit, so here is a v8 rebase which I really
> hope to close in this CF.

The alignment of this output looks a bit funny:

...
Checking for prepared transactions                            ok
Checking for contrib/isn with bigint-passing mismatch         ok
Checking for data type usage                                  checking all databases
ok
Checking for presence of required libraries                   ok
Checking database user is the install user                    ok
...


Also, you should put gettext_noop() calls into the .status = "Checking ..."
assignments and arrange to call gettext() where they are used, to maintain
the translatability.

view thread (25+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Reducing connection overhead in pg_upgrade compat check phase
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox