public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: Jelte Fennema <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Jesse Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Tue, 20 Jun 2023 09:21:14 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
<[email protected]>
<OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<[email protected]>
<CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On 2023-06-20 Tu 09:08, Tom Lane wrote:
> Andrew Dunstan<[email protected]> writes:
>> On 2023-06-19 Mo 17:07, Tom Lane wrote:
>>> Is koel tracking the right repo? It just spit up with a bunch of
>>> diffs that seem to have little to do with the commit it's claiming
>>> caused them:
>> Yeah, I changed it so that instead of just checking new commits it would
>> check the whole tree. The problem with the incremental approach is that
>> the next run it might turn green again but the issue would not have been
>> fixed.
> Ah.
>
>> I think this is a one-off issue. Once we clean up the tree the problem
>> would disappear and the commits it shows would be correct. I imaging
>> that's going to happen any day now?
> I can go fix the problems now that we know there are some (already).
> However, if what you're saying is that koel only checks recently-changed
> files, that's going to be pretty misleading in future too. If people
> don't react to such reports right away, they'll disappear, no?
>
>
That's what would have happened if I hadn't changed the way it worked
(and that's why I changed it). Now it doesn't just check recent commits,
it checks the whole tree, and will stay red until the tree is fixed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (142+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox