public inbox for [email protected]  

help / color / mirror / Atom feed

From: torikoshia <[email protected]>
To: Rahila Syed <[email protected]>
To: [email protected]
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Align memory context level numbering in pg_log_backend_memory_contexts()
Date: Thu, 17 Apr 2025 23:27:42 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAH2L28sk1ORSrL8oXQRe59O5HQV5CPJ4j0MuHfbzjcwPXqN-_g@mail.gmail.com>
References: <[email protected]>
	<CAApHDvpE6JS9F5kg+W4+p9TsiqFsPE+6XqEtD0P0HKNBoa9tYA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAApHDvrAQPuwOe5KZ9Kb3Lo68eQJJxaJW5_bBCf4-FwudNy2Sg@mail.gmail.com>
	<CAH2L28sk1ORSrL8oXQRe59O5HQV5CPJ4j0MuHfbzjcwPXqN-_g@mail.gmail.com>

Thanks for your review, Melih and Rahila.

On 2025-04-17 21:25, Rahila Syed wrote:
> Hi,
> 
>> The attached patch is how I think we should do it.
> 
> Thank you for the patch.
> I tested this patch and it works fine. I agree with the changes made
> in it.
> 
> Regarding v2 patch,
> -                       int                     level = 0;
> 
> Retaining the level variable will enhance the code readability, IMO.

As for the level variable, this change comes from the v1 patch, and I 
don't have a strong opinion about it.
However, if we decide to keep the level variable here, it might be more 
consistent to also define it in MemoryContextStatsDetail().


-- 
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Align memory context level numbering in pg_log_backend_memory_contexts()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox