public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tristan Partin <[email protected]>
To: [email protected]
Subject: Re: Make uselocale protection more consistent
Date: Mon, 3 Jul 2023 08:13:40 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CTNITWIN1G6L.CFIPH8SYNQQW@gonk>
References: <CTNITWIN1G6L.CFIPH8SYNQQW@gonk>

On 27.06.23 17:02, Tristan Partin wrote:
> This is a patch which implements an issue discussed in bug #17946[0]. It
> doesn't fix the overarching issue of the bug, but merely a consistency
> issue which was found while analyzing code by Heikki. I had originally
> submitted the patch within that thread, but for visibility and the
> purposes of the commitfest, I have re-sent it in its own thread.
> 
> [0]: https://www.postgresql.org/message-id/[email protected]

I notice that HAVE_USELOCALE was introduced much later than 
HAVE_LOCALE_T, and at the time the code was already using uselocale(), 
so perhaps the introduction of HAVE_USELOCALE was unnecessary and should 
be reverted.

I think it would be better to keep HAVE_LOCALE_T as encompassing any of 
the various locale_t-using functions, rather than using HAVE_USELOCALE 
as a proxy for them.  Otherwise you create weird situations like having 
#ifdef HAVE_WCSTOMBS_L inside #ifdef HAVE_USELOCALE, which doesn't make 
sense, I think.

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Make uselocale protection more consistent
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox