From: David Steele <david@pgmasters.net>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Subject: Re: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Date: Wed, 20 Mar 2019 14:30:53 +0400
Message-ID: <ff4c55c4-ac5b-e709-87c2-915cf14221f3@pgmasters.net> (raw)
In-Reply-To: <CAD21AoADrMShYbnbzmJ8GZk8KbE7tyedw2usgVfW45nec59+AA@mail.gmail.com>
References: <CABOikdN-ptGv0mZntrK2Q8OtfUuAjqaYMGmkdU1dCKFtUxVLrg@mail.gmail.com>
<CAD21AoBQT=t+R3gJFD2qkeQJzR7f4Uo9OvS2Fw4FbArZq5f8=A@mail.gmail.com>
<CABOikdPzhdUJniWhGiwXH0Ytz2fXLeDromZ3J5eaVf-d507=Dw@mail.gmail.com>
<CAD21AoDTKZ0VjRRrhVO1Vj5R3Dz_u8cJYNkC3a7vvFU6zjRGNw@mail.gmail.com>
<CABOikdPrs5x384-8WqQPfwRo57feOZw8ZoD2oFs9M2cFJF+aqw@mail.gmail.com>
<CAD21AoADrMShYbnbzmJ8GZk8KbE7tyedw2usgVfW45nec59+AA@mail.gmail.com>
Hi Pavan,
On 3/14/19 2:20 PM, Masahiko Sawada wrote:
> On Thu, Mar 14, 2019 at 5:17 PM Pavan Deolasee <pavan.deolasee@gmail.com> wrote:
>>
>> Ok. I will run some tests. But please note that this patch is a bug fix to address the performance issue that is caused by having to rewrite the entire table when all-visible bit is set on the page during first vacuum. So while we may do some more work during COPY FREEZE, we're saving a lot of page writes during next vacuum. Also, since the scan that we are doing in this patch is done on a page that should be in the buffer cache, we will pay a bit in terms of CPU cost, but not anything in terms of IO cost.
>
> Agreed. I had been misunderstanding this patch. The page scan during
> COPY FREEZE is necessary and it's very cheaper than doing in the first
> vacuum.
I have removed Ibrar as a reviewer since there has been no review from
them in three weeks, and too encourage others to have a look.
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, pavan.deolasee@gmail.com, sawada.mshk@gmail.com, jeff.janes@gmail.com, simon@2ndquadrant.com
Subject: Re: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
In-Reply-To: <ff4c55c4-ac5b-e709-87c2-915cf14221f3@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox