public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Subject: Re: test_compression, test module for low-level compression APIs (for 2b5ba2a0a141)
Date: Mon, 13 Apr 2026 10:08:16 -0400
Message-ID: <hp4xznm7dqt4ediyhezqysf22eljvu3mucbzsgvgehc6j2hk5v@laslwlkyixfg> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<pzafmppohkmqixgswjcyi6lyf2nsmbcyty4l6lciamskjl5nem@3i2am4uetkd2>
	<[email protected]>

Hi,

On 2026-04-13 12:52:59 +0900, Michael Paquier wrote:
> On Sun, Apr 12, 2026 at 10:20:43PM -0400, Andres Freund wrote:
> > There's really no reason for something like this to be a test doing tests via
> > SQL from what I can tell.
> > 
> > If it does not to be via SSL, can we please start to find a way to combine
> > tiny stuff like this?  We're working hard at making our tests grow
> > unsustainable.
> 
> If we care about `make check` rather than `make installcheck`

I don't really see the difference WRT that in this case? installcheck still
has regress.so available, no?


> it seems to me that a solution already exists in the shape of C function
> called through the main regression test suite.

I guess that'd work.  I don't really see the point in calling these via SQL,
tbh, but if that's easier for you, using a regress.c helper woul do the trick.


> Would this idea work for you when it comes to this proposal?

Yes.


I think we need to combine about half the modules in src/test/modules, the
current course is absurd:

16:  37
17:  46
18:  49
dev: 62


[Almost] All of them create a new initdb'd cluster. ~50MB of writes for a
short test is insane.  Doing low-level unittests by doing inter-process
communication from psql to the server, marshalling everything through text, is
insane.

Greetings,

Andres Freund

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: test_compression, test module for low-level compression APIs (for 2b5ba2a0a141)
  In-Reply-To: <hp4xznm7dqt4ediyhezqysf22eljvu3mucbzsgvgehc6j2hk5v@laslwlkyixfg>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox