From: Robbie Harwood <rharwood@redhat.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v2] GSSAPI encryption support
Date: Wed, 28 Oct 2015 13:41:03 -0400
Message-ID: <jlg7fm6zya8.fsf@thriss.redhat.com> (raw)
In-Reply-To: <CAMkU=1y9Dj8nrhOizsE860JcqrWErq_aTJ-Z_qpmXxAJDu8Byw@mail.gmail.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
<CAB7nPqRGQ60PWLb-CLLrvMoQwPAbnu-961W+xGPvG62RMSkcZQ@mail.gmail.com>
<jlg37yo7mj2.fsf@thriss.redhat.com>
<CAB7nPqTQM5dfhMh6yskkt=w1032iJ8ggnJu9y+tZBmwwhzEZKw@mail.gmail.com>
<jlgsi6n8rum.fsf@thriss.redhat.com>
<CAB7nPqQ7daftDPRTxvyPBFLmZnX-0vTku+H1ft7tqNmSxca3BA@mail.gmail.com>
<CAB7nPqTgr+aOZFmbORwxX9sZ7f3re4FuQFZyqdHP8AnOZPqrgw@mail.gmail.com>
<jlgvbba5fu4.fsf@thriss.redhat.com>
<jlgsi5xb7kk.fsf@thriss.redhat.com>
<CAMkU=1y9Dj8nrhOizsE860JcqrWErq_aTJ-Z_qpmXxAJDu8Byw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Jeff Janes <jeff.janes@gmail.com> writes:
> On Tue, Sep 29, 2015 at 7:53 AM, Robbie Harwood <rharwood@redhat.com> wrote:
>> Robbie Harwood <rharwood@redhat.com> writes:
>>
>>>>>> Michael Paquier <michael.paquier@gmail.com> writes:
>>>>>>
>>>>>>> Well, the issue is still here: login through gssapi fails with
>>>>>>> your patch, not with HEAD. This patch is next on my review list by
>>>>>>> the way so I'll see what I can do about it soon even if I am in
>>>>>>> the US for Postgres Open next week. Still, how did you test it? I
>>>>>>> am just creating by myself a KDC, setting up a valid credential
>>>>>>> with kinit, and after setting up Postgres for this purpose the
>>>>>>> protocol communication just fails.
>>>
>>> I have no issues, no sync loss; nothing is amiss as far as I can see.
>>> If there is actually a problem here, I need more information from you.
>>> At the very least, as previously mentioned, I need to know what
>>> messages went over the wire to/from the server before it occurred, and
>>> what command (if it it made it to command processing) it was in the
>>> midst of sending.
>>
>> Any follow-up on this? I'd really like my code to be bug-free.
>
> I don't know if this is worth posting as the patch is currently
> returned with feedback and you are redoing it in a different way, but
> with your patch I get this error when connecting:
>
> lost synchronization with server: got message type "T", length 27
> The connection to the server was lost. Attempting reset: Failed.
>
> I only get the error when connection to a patched server from a
> patched libpq. If either is unpatched, then there is no problem.
>
> Let me know if this is worth looking into.
Definitely good to know, and I appreciate your testing. It's probably
not worth looking into right now, but please do test the next version of
the code as well.
Thanks!
--Robbie
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rharwood@redhat.com, jeff.janes@gmail.com, michael.paquier@gmail.com
Subject: Re: [PATCH v2] GSSAPI encryption support
In-Reply-To: <jlg7fm6zya8.fsf@thriss.redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox