From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Command Triggers, patch v11
Date: Mon, 27 Feb 2012 20:37:09 +0100
Message-ID: <m28vjo2hlm.fsf@2ndQuadrant.fr> (raw)
In-Reply-To: <CAA-aLv4jkA-s9y+bW_53zfz0Zt2azULQ2dppQYoRRpWmW2fvNw@mail.gmail.com>
References: <m24nufq466.fsf@2ndQuadrant.fr>
<CAA-aLv5H5_ALMRZFatX-wDEz1meMvQVJOsBBFTYox65jzAoN5Q@mail.gmail.com>
<CAA-aLv4w9B27QP17zU-osme58gks0yEH7j8p5p1tKCWp2oq_Hw@mail.gmail.com>
<CAA-aLv6Was-jZmigbH3_eLH3eqsEUPpf-p7FT2s1FjBdXAbeNA@mail.gmail.com>
<CAA-aLv7=+b+CiaDrWi7bKBtnW=jMarVC1HpB0a+erTKP3B=5Zw@mail.gmail.com>
<CAA-aLv4jkA-s9y+bW_53zfz0Zt2azULQ2dppQYoRRpWmW2fvNw@mail.gmail.com>
Thom Brown <thom@linux.com> writes:
> CREATE COMMAND TRIGGER test_cmd_trg
> BEFORE CREATE SCHEMA,
> CREATE OPERATOR,
> CREATE COLLATION,
> CREATE CAST
> EXECUTE PROCEDURE my_func();
>
> I couldn't drop it completely unless I specified all of those commands. Why?
Because I couldn't find a nice enough way to implement that given the
shared infrastructure Robert and Kaigai did put into place to handle
dropping of objects. It could be that I didn't look hard enough, I'll
be happy to get back that feature.
> Incidentally, I've noticed the DROP COMMAND TRIGGER has a mistake in the syntax.
Thanks, fix will be in the next version.
> The documentation also needs to cover the pg_cmdtrigger catalogue as
> it's not mentioned anywhere.
That too, working on it now, adding forgotten forms you reported and
more, adding regression tests, fixing weird cases, getting there :)
> I'm enjoying playing with this feature though btw. :)
Thanks :)
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dimitri@2ndQuadrant.fr, thom@linux.com
Subject: Re: Command Triggers, patch v11
In-Reply-To: <m28vjo2hlm.fsf@2ndQuadrant.fr>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox