From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Command Triggers, patch v11
Date: Sun, 26 Feb 2012 15:12:43 +0100
Message-ID: <m2zkc5of8k.fsf@2ndQuadrant.fr> (raw)
In-Reply-To: <CAA-aLv5aEwUVQ1zOCNvDzzPTZ71Z5BGSuZ5+LKWTktbUz_3tYw@mail.gmail.com>
References: <m24nufq466.fsf@2ndQuadrant.fr>
<CAA-aLv5H5_ALMRZFatX-wDEz1meMvQVJOsBBFTYox65jzAoN5Q@mail.gmail.com>
<m2y5rrktqi.fsf@2ndQuadrant.fr>
<CAA-aLv6kfradv_+LVC=TyS=UR3PD2vuMsS++A8BbvSW9H6mQ_g@mail.gmail.com>
<CAA-aLv4_dfsAKS_AfReYw86KTkskhDDWycMc+Jb0vprc-OjnsA@mail.gmail.com>
<CAA-aLv5i8tOyCivP6fYNgMUL2bi3atxdX-RBh791G7jr=ehGmA@mail.gmail.com>
<CAA-aLv6AUdGFBA4=qkKExHxSiJ3fybV71S=KHGP2uNgJ2OV7uA@mail.gmail.com>
<CAA-aLv6qDiz3pdxwZwMk_ABmERSm1sOCfZ4CMiy4qVJZYb=o6g@mail.gmail.com>
<CAA-aLv7G0WLrQ3fgZ76DybrEmgGriJ-+otgsf6TyOrEcJfWcFw@mail.gmail.com>
<CAA-aLv5aEwUVQ1zOCNvDzzPTZ71Z5BGSuZ5+LKWTktbUz_3tYw@mail.gmail.com>
Thanks for your further testing!
Thom Brown <thom@linux.com> writes:
> Further testing reveals a problem with FTS configurations when using
> the example function provided in the docs:
Could you send me your tests so that I add them to the proper regression
test? I've been lazy on one or two object types and obviously that's
where I have to check some more.
> Also command triggers for DROP CONVERSION aren't working. A glance at
> pg_cmdtrigger shows that the system views the command as "DROP
> CONVERSION_P".
That's easy to fix, that's a typo in gram.y. I'm not seeing other ones
like this though.
- | DROP CONVERSION_P { $$ = "DROP CONVERSION_P"; }
+ | DROP CONVERSION_P { $$ = "DROP CONVERSION"; }
> What is DROP ASSERTION? It's showing as a valid command for a command
> trigger, but it's not documented.
It's a Not Implemented Feature for which we have the grammar support to
be able to fill a standard compliant checkbox, or something like that.
It could be better for me to remove explicit support for it in the
command triggers patch?
> I've noticed that ALTER <object> name OWNER TO role doesn't result in
> any trigger being fired except for tables.
>
> ALTER OPERATOR FAMILY .... RENAME TO ... doesn't fire command triggers.
>
> ALTER OPERATOR CLASS with RENAME TO or OWNER TO doesn't fire command
> triggers, but with SET SCHEMA it does.
It seems I've forgotten to add some support here, that happens in
alter.c and is easy enough to check and complete, thanks for the
testing.
> And there's no command trigger available for ALTER VIEW.
Will add.
> I'll hold off on testing any further until a new patch is available.
That should happen soon. Ah, the joys of coding while kids are at home
thanks to school holidays. I can't count how many times I've been killed
by a captain and married to a princess while writing that patch, sorry
about those hiccups here.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dimitri@2ndQuadrant.fr, thom@linux.com
Subject: Re: Command Triggers, patch v11
In-Reply-To: <m2zkc5of8k.fsf@2ndQuadrant.fr>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox